Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for of #50594

Merged
merged 2 commits into from
Nov 24, 2023
Merged

test: replace forEach with for of #50594

merged 2 commits into from
Nov 24, 2023

Conversation

RBrNx
Copy link
Contributor

@RBrNx RBrNx commented Nov 7, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@RafaelGSS RafaelGSS added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 7, 2023
RafaelGSS
RafaelGSS approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@RafaelGSS RafaelGSS added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55480/

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55482/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55488/

@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55506/

@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55519/

@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55538/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55542/

@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Open
27 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55563/

This was referenced Nov 12, 2023
Open
Open
Open
Open
@RBrNx
Copy link
Contributor Author

RBrNx commented Nov 15, 2023

Hey @RafaelGSS @marco-ippolito @lpinca @jasnell, I noticed that some of the checks seem to be consistently failing for this PR - is there an issue with the code or is it a CI issue preventing the checks from passing?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55821/

@RafaelGSS
Copy link
Member

Hey @RafaelGSS @marco-ippolito @lpinca @jasnell, I noticed that some of the checks seem to be consistently failing for this PR - is there an issue with the code or is it a CI issue preventing the checks from passing?

I suspect this should be fixed on main. Would you mind rebasing this pr?

@RBrNx
Copy link
Contributor Author

RBrNx commented Nov 22, 2023

Hey @RafaelGSS, rebased and pushed! Hopefully the CI checks pass this time 😄

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55853/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/50594
✔  Done loading data for nodejs/node/pull/50594
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with for of (#50594)
Author     Conor Watson  (@RBrNx, first-time contributor)
Branch     RBrNx:nodeconfeu-first-contrib -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    2
 - test: replace forEach with for of
 - fixup! test: replace forEach with for of
Committers 1
 - RBrNx 
PR-URL: https://github.com/nodejs/node/pull/50594
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50594
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: replace forEach with for of
   ⚠  - fixup! test: replace forEach with for of
   ℹ  This PR was created on Tue, 07 Nov 2023 14:59:07 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50594#pullrequestreview-1717930171
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50594#pullrequestreview-1717957296
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50594#pullrequestreview-1718803041
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50594#pullrequestreview-1726071964
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-22T12:52:54Z: https://ci.nodejs.org/job/node-test-pull-request/55853/
- Querying data for job/node-test-pull-request/55853/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6981633672

@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 303654c into nodejs:main Nov 24, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 303654c

martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@RBrNx @martenrichter
test: replace forEach with for of
9027578 
PR-URL: nodejs#50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@RBrNx
test: replace forEach with for of
6d4439a 
PR-URL: nodejs#50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@RBrNx @RafaelGSS
test: replace forEach with for of
cbc7798 
PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@RBrNx @RafaelGSS
test: replace forEach with for of
b1b6c44 
PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@RBrNx @RafaelGSS
test: replace forEach with for of
b5e8afa 
PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@RBrNx @UlisesGascon
test: replace forEach with for of
002481c 
PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@RBrNx @UlisesGascon
test: replace forEach with for of
eb10c25 
PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@RBrNx @UlisesGascon
test: replace forEach with for of
8ba10bb 
PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@RBrNx @UlisesGascon
test: replace forEach with for of
4544593 
PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RBrNx @nodejs-github-bot @RafaelGSS @jasnell @lpinca @marco-ippolito