Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport 8d00c2c from v8 upstream #5024

Closed
wants to merge 1 commit into from

Commits on Feb 1, 2016

  1. deps: backport 8d00c2c from v8 upstream

    Original commit message:
    
    ```
    Stop profiler on isolate teardown if still running
    
    If the profiler is started via the API and not stopped, V8 will
     intermittently crash during isolate teardown.
    
    The fix is to run the DeleteAllProfiles function in Isolate::Deinit()
     if cpu_profiler_ still exists.
    
    https://groups.google.com/forum/#!topic/v8-dev/WsIlpbaD4mo
    
    TEST= Run in debug mode, if you start a profile and don't stop it,
     this assert should fail:
    
       Fatal error in ../src/profiler/cpu-profiler.cc, line 414
       Check failed: !is_profiling_.
    
    Review URL: https://codereview.chromium.org/1526253005
    
    Cr-Commit-Position: refs/heads/master@{nodejs#32953}
    ```
    gibfahn committed Feb 1, 2016
    Configuration menu
    Copy the full SHA
    ab1b2a0 View commit details
    Browse the repository at this point in the history