stream: refactor writable _write #50198
Merged
+18
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
anonrig
approved these changes
Oct 16, 2023
marco-ippolito
approved these changes
Oct 16, 2023
github-actions
bot
removed
the
request-ci
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 17, 2023
ronag
commented
Oct 17, 2023
| @@ -38,7 +38,7 @@ const GHI = new Uint8Array([0x47, 0x48, 0x49]); | |||
| assert(!(chunk instanceof Buffer)); | |||
| assert(chunk instanceof Uint8Array); | |||
| assert.strictEqual(chunk, ABC); | |||
| assert.strictEqual(encoding, 'utf8'); | |||
| assert.strictEqual(encoding, undefined); | |||
github-actions
bot
removed
the
request-ci
ronag
added
the
author ready
This was referenced Oct 19, 2023
ronag
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50198 ✔ Done loading data for nodejs/node/pull/50198 ----------------------------------- PR info ------------------------------------ Title stream: refactor writable _write (#50198) Author Robert Nagy (@ronag) Branch ronag:writable-clean -> nodejs:main Labels author ready, needs-ci Commits 1 - stream: refactor writable _write Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: refactor writable _write ℹ This PR was created on Mon, 16 Oct 2023 13:34:39 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680096270 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680107397 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1681609596 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-10-18T13:41:53Z: https://ci.nodejs.org/job/node-test-pull-request/54940/ - Querying data for job/node-test-pull-request/54940/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6597965086 |
|
@ronag can you please rebase to fix the git conflicts? |
ronag
added
request-ci
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 23, 2023
github-actions
bot
removed
the
request-ci
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 23, 2023
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
27 tasks
ronag
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/50198 ✔ Done loading data for nodejs/node/pull/50198 ----------------------------------- PR info ------------------------------------ Title stream: refactor writable _write (#50198) Author Robert Nagy (@ronag) Branch ronag:writable-clean -> nodejs:main Labels author ready, needs-ci Commits 1 - stream: refactor writable _write Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50198 Reviewed-By: Yagiz Nizipli Reviewed-By: Marco Ippolito Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: refactor writable _write ℹ This PR was created on Mon, 16 Oct 2023 13:34:39 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680096270 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680107397 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1681609596 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-23T21:53:15Z: https://ci.nodejs.org/job/node-test-pull-request/55168/ - Querying data for job/node-test-pull-request/55168/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6623263972 |
nodejs-github-bot
added
the
commit-queue-failed
anonrig
approved these changes
Oct 24, 2023
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in dbed031 |
This was referenced Oct 25, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50198 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50198 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50198 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the implementation a bit to make future work easier.