typings: Use Symbol.dispose and Symbol.asyncDispose in types
#50123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikeee
changed the title
Symbol.dispose and Symbol.asyncDispose in typesSymbol.dispose and Symbol.asyncDispose in types
nikeee
force-pushed
the
enhancement/symbol-dispose
branch
from
255b5d5
to
6643fa4
Compare
nikeee
force-pushed
the
enhancement/symbol-dispose
branch
from
6643fa4
to
742ccdc
Compare
aduh95
approved these changes
Oct 10, 2023
aduh95
added
author ready
|
@aduh95 do you have any advice for me to meet the required code coverage? |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50123 ✔ Done loading data for nodejs/node/pull/50123 ----------------------------------- PR info ------------------------------------ Title typings: Use `Symbol.dispose` and `Symbol.asyncDispose` in types (#50123) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nikeee:enhancement/symbol-dispose -> nodejs:main Labels author ready, typings Commits 1 - typings: use `Symbol.dispose` and `Symbol.asyncDispose` in types Committers 1 - Niklas Mollenhauer PR-URL: https://github.com/nodejs/node/pull/50123 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50123 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 10 Oct 2023 15:50:29 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50123#pullrequestreview-1668916117 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6498021995 |
debadree25
approved these changes
Oct 14, 2023
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9df864d |
2 tasks
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50123 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50123 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both symbols seem to be available by now. TS 5.2 released in august, the TODO is from june.