Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update undici to 5.25.4 #50025

Merged
merged 1 commit into from
Oct 8, 2023
Merged

deps: update undici to 5.25.4 #50025

merged 1 commit into from
Oct 8, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Oct 3, 2023 •
edited
Loading

This is an automated update of undici to 5.25.4.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Oct 3, 2023
@KhafraDev
Copy link
Member

test failures seem like a weird issue with require where it's trying to require internal deps?

@KhafraDev
Copy link
Member

@fastify/busboy imports node:stream which causes the following error:

Missing internal module 'internal/deps/node:stream'
TypeError: Missing internal module 'internal/deps/node:stream'

@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 5.25.3 deps: update undici to 5.25.4 Oct 4, 2023
@mcollina
Copy link
Member

mcollina commented Oct 4, 2023

I think we need to revert the node:stream lookup in @fastify/busboy.

@KhafraDev
Copy link
Member

it seems like a bug in the wpt runner, @panva maybe?

@panva
Copy link
Member

panva commented Oct 4, 2023

@KhafraDev it doesn't seem like it to me

Missing internal module 'internal/deps/node:stream'
TypeError: Missing internal module 'internal/deps/node:stream'
    at requireBuiltin (node:internal/bootstrap/realm:422:19)
    at requireWithFallbackInDeps (node:internal/bootstrap/realm:432:10)
    at node_modules/@fastify/busboy/lib/main.js (node:internal/deps/undici/undici:3392:26)

@KhafraDev
Copy link
Member

KhafraDev commented Oct 4, 2023 •
edited
Loading

I don't understand why it's trying to require internal/deps/node:stream when @fastify/busboy is only importing node:stream. Is that expected?

https://github.com/nodejs/node/pull/50025/files#diff-f516ab824a7722da938a4c7c851520d39731ddeb4f7198dff4e932c5d4f8fdf7R3392

(sorry I didn't know who else to ping)

@mcollina
Copy link
Member

mcollina commented Oct 4, 2023

I think we can revert that change in @fastify/busboy.

@KhafraDev
Copy link
Member

KhafraDev commented Oct 4, 2023 •
edited
Loading

this is actually a bug in node, but removing the node: prefix will also work.

node/lib/internal/bootstrap/realm.js

Lines 428 to 433 in b1ada0a

function requireWithFallbackInDeps(request) {
if (!BuiltinModule.map.has(request)) {
request = `internal/deps/${request}`;
}
return requireBuiltin(request);
}

@KhafraDev KhafraDev mentioned this pull request Oct 4, 2023
Merged
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54590/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54591/

@github-actions github-actions bot mentioned this pull request Oct 7, 2023
Open
19 tasks
@mcollina
Copy link
Member

mcollina commented Oct 7, 2023

The CI is not flaky, there is a tiny bug here.

@targos targos force-pushed the actions/tools-update-undici branch from a705b57 to 9253851 Compare October 7, 2023 09:06
@targos
Copy link
Member

targos commented Oct 7, 2023

Rebased to include 6b599a3 and make a single commit.

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54605/

@github-actions github-actions bot mentioned this pull request Oct 8, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54608/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2023
mcollina
mcollina approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Oct 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 588784e into main Oct 8, 2023
57 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch October 8, 2023 06:39
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 588784e

@github-actions github-actions bot mentioned this pull request Oct 9, 2023
Open
23 tasks
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
This was referenced Oct 10, 2023
Open
Open
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@nodejs-github-bot @alexfernandez
deps: update undici to 5.25.4
af6e489 
PR-URL: nodejs#50025
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 11, 2023
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 26, 2023
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@nodejs-github-bot @debadree25
deps: update undici to 5.25.4
57903d8 
PR-URL: nodejs#50025
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

@panva panva panva approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @KhafraDev @mcollina @panva @targos