Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reserve 119 for Electron 28 #50020

Merged
merged 1 commit into from
Oct 3, 2023
Merged

doc: reserve 119 for Electron 28 #50020

merged 1 commit into from
Oct 3, 2023

Conversation

dsanders11
Copy link
Contributor

This PR reserves NMV 119 for Electron 28.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 3, 2023
@dsanders11
Copy link
Contributor Author

Not sure if this will interfere with #49870, but happy to tweak it as needed.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit f3ed57b into nodejs:main Oct 3, 2023
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f3ed57b

@dsanders11 dsanders11 deleted the nmv-electron-28 branch October 3, 2023 16:22
@dsanders11 dsanders11 mentioned this pull request Oct 3, 2023
Merged
1 task
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@dsanders11 @alexfernandez
doc: reserve 119 for Electron 28
dc1bd39 
Signed-off-by: David Sanders <[email protected]>
PR-URL: nodejs#50020
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@dsanders11 @targos
doc: reserve 119 for Electron 28
fe47c8a 
Signed-off-by: David Sanders <[email protected]>
PR-URL: #50020
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@targos targos added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Nov 27, 2023
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@dsanders11 @debadree25
doc: reserve 119 for Electron 28
e006c7a 
Signed-off-by: David Sanders <[email protected]>
PR-URL: nodejs#50020
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dsanders11 @nodejs-github-bot @anonrig @targos @richardlau @MoLow