doc: minor improvement to HTTPS doc #5002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-52
added
https
|
LGTM! |
| @@ -243,3 +243,4 @@ var req = https.request(options, (res) => { | |||
| [`tls.connect()`]: tls.html#tls_tls_connect_options_callback | |||
| [`tls.createServer()`]: tls.html#tls_tls_createserver_options_secureconnectionlistener | |||
| [`url.parse()`]: url.html#url_url_parse_urlstr_parsequerystring_slashesdenotehost | |||
| [`Buffer`]: buffer.html#buffer_buffer | |||
There was a problem hiding this comment.
This page maintains this list in ascending order (in fact all the pages should do this). Can you please put this in the right place?
There was a problem hiding this comment.
Ok, will do soon
Add link to Buffer page.
|
@thefourtheye Done |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 1, 2016
Add link to Buffer page. PR-URL: #5002 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 4736eec |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Add link to Buffer page. PR-URL: #5002 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Add link to Buffer page. PR-URL: #5002 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Add link to Buffer page. PR-URL: #5002 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Add link to Buffer page. PR-URL: #5002 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Add link to Buffer page. PR-URL: nodejs#5002 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add link to Buffer page.