-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update eslint to 8.50.0 #49989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Oct 1, 2023
lpinca
approved these changes
Oct 1, 2023
MoLow
approved these changes
Oct 1, 2023
tniessen
approved these changes
Oct 1, 2023
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 3, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Oct 3, 2023
Commit Queue failed- Loading data for nodejs/node/pull/49989 ✔ Done loading data for nodejs/node/pull/49989 ----------------------------------- PR info ------------------------------------ Title tools: update eslint to 8.50.0 (#49989) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-eslint -> nodejs:main Labels tools, commit-queue-squash Commits 2 - tools: update eslint to 8.50.0 - test: fix lint errors Committers 2 - Node.js GitHub Bot - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/49989 Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49989 Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 01 Oct 2023 05:44:59 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49989#pullrequestreview-1651838774 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49989#pullrequestreview-1651844432 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49989#pullrequestreview-1651891026 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6393402095 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 3, 2023
lpinca
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Oct 3, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 3, 2023
Landed in 581434e |
This was referenced Oct 4, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49989 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49989 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49989 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49989 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49989 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #49989 Backport-PR-URL: #50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49989 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49989 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49989 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of eslint to 8.50.0.