Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix var redeclarations in test-os #4990

Closed
wants to merge 1 commit into from
Closed

test: fix var redeclarations in test-os #4990

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 31, 2016

No description provided.

@Trott Trott added os Issues and PRs related to the os subsystem. test Issues and PRs related to the tests. lts-watch-v4.x labels Jan 31, 2016
@targos
Copy link
Member

targos commented Jan 31, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM if CI is green: https://ci.nodejs.org/job/node-test-pull-request/1477/

@r-52
Copy link
Contributor

r-52 commented Feb 1, 2016

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Feb 2, 2016
@Trott @jasnell
test: fix var redeclarations in test-os
7caeda2 
PR-URL: #4990
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 2, 2016

Landed in 7caeda2

@jasnell jasnell closed this Feb 2, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@Trott @rvagg
test: fix var redeclarations in test-os
b16b360 
PR-URL: #4990
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
test: fix var redeclarations in test-os
7c796f9 
PR-URL: #4990
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
test: fix var redeclarations in test-os
2b711d5 
PR-URL: #4990
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
test: fix var redeclarations in test-os
54a4014 
PR-URL: #4990
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: fix var redeclarations in test-os
c32e68e 
PR-URL: nodejs#4990
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the test-os-no-redeclare branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
os Issues and PRs related to the os subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @targos @jasnell @r-52 @jbergstroem @MylesBorins