Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove var redeclarations in test-crypto-* #4981

Closed
wants to merge 4 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 30, 2016

No description provided.

@Trott Trott added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. lts-watch-v4.x labels Jan 30, 2016
@@ -46,11 +46,11 @@ assert.throws(function() {
}, 'not enough data');

// Test HMAC
var h1 = crypto.createHmac('sha1', 'Node')
const hmacHash = crypto.createHmac('sha1', 'Node')
.update('some data')
.update('to hmac')
.digest('hex');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit: the above 3 lines should probably be re-aligned with the . on line 49.

Same goes for the other instances of this in this and the other changed files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed the alignment of all the . characters. PTAL

@mscdex
Copy link
Contributor

mscdex commented Jan 31, 2016

Some minor nits and a question, but otherwise LGTM if CI is ok with it.

@Trott
Copy link
Member Author

Trott commented Jan 31, 2016

Missed one so I rebased and added it. PTAL

// FIPS does not support MD5.
if (common.hasFipsCrypto && hash == 'md5')
continue;
var result = crypto.createHmac(hash, wikipedia[i]['key'])
const result = crypto.createHmac(hash, wikipedia[i]['key'])
.update(wikipedia[i]['data'])
.digest('hex');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was missed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks. Fixed it!

@mscdex
Copy link
Contributor

mscdex commented Jan 31, 2016

LGTM if CI is happy: https://ci.nodejs.org/job/node-test-pull-request/1453/

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
PR-URL: #4981
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

Squashed and landed in 2c97bd4

@jasnell jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #4981
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4981
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4981
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #4981
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4981
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the test-crypto-no-redeclare branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants