test: remove var redeclarations in test-crypto-* #4981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
crypto
| @@ -46,11 +46,11 @@ assert.throws(function() { | |||
| }, 'not enough data'); | |||
|
|
|||
| // Test HMAC | |||
| var h1 = crypto.createHmac('sha1', 'Node') | |||
| const hmacHash = crypto.createHmac('sha1', 'Node') | |||
| .update('some data') | |||
| .update('to hmac') | |||
| .digest('hex'); | |||
There was a problem hiding this comment.
A minor nit: the above 3 lines should probably be re-aligned with the . on line 49.
Same goes for the other instances of this in this and the other changed files.
There was a problem hiding this comment.
OK, fixed the alignment of all the . characters. PTAL
|
Some minor nits and a question, but otherwise LGTM if CI is ok with it. |
Trott
force-pushed
the
test-crypto-no-redeclare
branch
from
40898af
to
46b5e3e
Compare
|
Missed one so I rebased and added it. PTAL |
| // FIPS does not support MD5. | ||
| if (common.hasFipsCrypto && hash == 'md5') | ||
| continue; | ||
| var result = crypto.createHmac(hash, wikipedia[i]['key']) | ||
| const result = crypto.createHmac(hash, wikipedia[i]['key']) | ||
| .update(wikipedia[i]['data']) | ||
| .digest('hex'); |
|
LGTM if CI is happy: https://ci.nodejs.org/job/node-test-pull-request/1453/ |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 1, 2016
PR-URL: #4981 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Squashed and landed in 2c97bd4 |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4981 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4981 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4981 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4981 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4981 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.