Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: remove variable redeclaration #4977

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 30, 2016

match and filter are declared twice with var in repl.js. Declare the variables only once.

`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.
@Trott Trott added repl Issues and PRs related to the REPL subsystem. lts-watch-v4.x labels Jan 30, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 30, 2016

LGTM if CI is ok with it.

@Trott
Copy link
Member Author

Trott commented Jan 30, 2016

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

Landed in ba81d15

@jasnell jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: #4977
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
`match` and `filter` are declared twice with `var` in `repl.js`.
Declare the variables only once.

PR-URL: nodejs#4977
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the repl-no-redeclare branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants