Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PipeWrap to use uv_pipe_bind2 and uv_pipe_connect2 to restore ability to connect to abstract domain sockets #49667

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Update PipeWrap to use uv_pipe_bind2 and uv_pipe_connect2 to restore ability to connect to abstract domain sockets #49667

merged 2 commits into from
Sep 18, 2023

Commits on Sep 15, 2023

  1. src: port Pipe to uv_pipe_bind2, uv_pipe_connect2 

    The introduction of the uv_pipe_bind2 and uv_pipe_connect2 methods in
libuv v1.46.0 changed the behaviour of uv_pipe_bind and uv_pipe_connect.
This broke the ability to connect to abstract domain sockets on linux.
This change ports PipeWrap to use the new uv_pipe_bind2 and
uv_pipe_connect2 methods to restore abstract domain socket support.

Fixes: nodejs#49656
Refs: libuv/libuv#4030
    @ggoodman
    ggoodman committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    85e27ed View commit details
    Browse the repository at this point in the history

  2. test: adds linux-only test for abstract sockets 

    Introduce a new linux-only test for binding to an abstract unix socket
and then making an http request against that socket.

Refs: nodejs#49656
    @ggoodman
    ggoodman committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8afecf1 View commit details
    Browse the repository at this point in the history