Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: scope loop variables #4965

Closed
wants to merge 2 commits into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 30, 2016

Refactor instances in lib where a loop variable is redeclared in the
same scope with var. In these cases, let can be used to scope the
variable declarations more precisely.

Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.
@Trott Trott added lts-watch-v4.x lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 30, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 30, 2016

IMHO with regard to these variable definition changes, I think we should either avoid or at least be careful with using let in hot code/paths since v8 apparently still imposes a significant performance penalty when using let. const however does not seem to cause any performance regressions.

@Trott
Copy link
Member Author

Trott commented Jan 30, 2016

@mscdex I've changed this to avoid the whole "Is let performant yet?" question. PTAL

@mscdex
Copy link
Contributor

mscdex commented Jan 30, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Feb 1, 2016

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.

PR-URL: #4965
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

Landed in 089d84f

@jasnell jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.

PR-URL: #4965
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.

PR-URL: #4965
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.

PR-URL: #4965
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.

PR-URL: #4965
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.

PR-URL: nodejs#4965
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the lib-no-redeclare branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants