Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: improve formatList in errors.js #49642

Merged
merged 1 commit into from
Sep 29, 2023
Merged

errors: improve formatList in errors.js #49642

merged 1 commit into from
Sep 29, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 14, 2023 •
edited
Loading

This PR improves formatLIst in errors.js
The benchmarks:

main:

aras@aras-Lenovo-Legion-5-17ARH05H:~/workspace/node$ ./node benchmark/error/format-list.js 
error/format-list.js input="" n=10000000: 19,674,229.0009035
error/format-list.js input="a" n=10000000: 17,898,703.51886578
error/format-list.js input="a,b" n=10000000: 8,773,227.708163619
error/format-list.js input="a,b,c" n=10000000: 5,988,210.708969075

PR:

aras@aras-Lenovo-Legion-5-17ARH05H:~/workspace/node$ ./node benchmark/error/format-list.js 
error/format-list.js input="" n=10000000: 544,845,141.1173433
error/format-list.js input="a" n=10000000: 543,086,471.205501
error/format-list.js input="a,b" n=10000000: 37,940,629.811950795
error/format-list.js input="a,b,c" n=10000000: 6,147,421.564903789

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Sep 14, 2023
@Uzlopak Uzlopak changed the title perf: improve formatList in errors.js perf: improve performance of formatList in errors.js Sep 14, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53942/

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 14, 2023

@anonrig
Can you please add the performance tags to my PRs please?

@anonrig anonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 14, 2023
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53952/

@mscdex mscdex changed the title perf: improve performance of formatList in errors.js errors: improve formatList in errors.js Sep 15, 2023
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 18, 2023

@anonrig What is necessary to get this PR merged?

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@anonrig
Copy link
Member

anonrig commented Sep 25, 2023

When CI finishes, we can land this PR.

@anonrig
Copy link
Member

anonrig commented Sep 25, 2023

Pending benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1418/

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54224/

@github-actions github-actions bot mentioned this pull request Sep 27, 2023
Open
21 tasks
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Open
19 tasks
@H4ad H4ad mentioned this pull request Sep 29, 2023
Open
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54349/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4f84a3d into nodejs:main Sep 29, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4f84a3d

@Uzlopak Uzlopak deleted the improve-format-list branch September 29, 2023 11:07
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@Uzlopak @alexfernandez
errors: improve formatList in errors.js
c0091cc 
PR-URL: nodejs#49642
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@Uzlopak @targos
errors: improve formatList in errors.js
e66991e 
PR-URL: #49642
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@Uzlopak @debadree25
errors: improve formatList in errors.js
b3feb52 
PR-URL: nodejs#49642
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Uzlopak @nodejs-github-bot @anonrig @aduh95 @LiviaMedeiros