Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: refactor redeclared variable #4962

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 30, 2016

homedir was declared with var twice in the same scope in
lib/module.js. This change makes it a single declaration.

`homedir` was declared with `var` twice in the same scope in
`lib/module.js`. This change makes it a single declaration.
@Trott Trott added module Issues and PRs related to the module subsystem. lts-watch-v4.x labels Jan 30, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 30, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Jan 30, 2016

@JungMinu
Copy link
Member

LGTM

r-52 pushed a commit that referenced this pull request Jan 31, 2016
`homedir` was declared with `var` twice in the same scope in
`lib/module.js`. This change makes it a single declaration.

PR-URL: #4962
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
@r-52
Copy link
Contributor

r-52 commented Jan 31, 2016

Thanks! Landed in 0c113e8

@r-52 r-52 closed this Jan 31, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
`homedir` was declared with `var` twice in the same scope in
`lib/module.js`. This change makes it a single declaration.

PR-URL: #4962
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
`homedir` was declared with `var` twice in the same scope in
`lib/module.js`. This change makes it a single declaration.

PR-URL: #4962
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
`homedir` was declared with `var` twice in the same scope in
`lib/module.js`. This change makes it a single declaration.

PR-URL: #4962
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
`homedir` was declared with `var` twice in the same scope in
`lib/module.js`. This change makes it a single declaration.

PR-URL: #4962
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
`homedir` was declared with `var` twice in the same scope in
`lib/module.js`. This change makes it a single declaration.

PR-URL: nodejs#4962
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
@Trott Trott deleted the module-no-redeclare branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants