Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: add support for mocking setImmediate timer #49397

Merged
merged 5 commits into from
Aug 31, 2023
Merged

test_runner: add support for mocking setImmediate timer #49397

merged 5 commits into from
Aug 31, 2023

Commits on Aug 29, 2023

  1. test_runner: add support for setImmediate

    @ErickWendel
    ErickWendel committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    41d7fc3 View commit details
    Browse the repository at this point in the history

  2. add @ovflowd suggestion 

    Co-authored-by: CW <[email protected]>
    @ErickWendel @ovflowd
    ErickWendel and ovflowd authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c1d70cc View commit details
    Browse the repository at this point in the history

  3. test: change mock callCount to common.mustCall 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4fbcd69 View commit details
    Browse the repository at this point in the history

  4. test: explicit add mustcall 1 times 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a8c1ede View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. test_runner: apply sugestions 

    Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Moshe Atlow <[email protected]>
    @ErickWendel @ljharb @MoLow
    3 people committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    962e14a View commit details
    Browse the repository at this point in the history