Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add DEBUG_ONLY to Makefile to support debug-only builds #49229

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

build: add DEBUG_ONLY to Makefile to support debug-only builds #49229

wants to merge 3 commits into from

Commits on Aug 18, 2023

  1. build: add DEBUG_ONLY to Makefile to support debug-only builds 

    Previously, when setting BUILDTYPE=Debug, `make` would build both
the release build and the debug build and use the release build
to run certain build steps before running the tests using the
debug build. This patch adds another DEBUG_ONLY switch to the
Makefile. When it's used in conjunction with BUILDTYPE=Debug
Node.js no longer builds the release build and instead would
just use the debug build to complete the build steps.

```
DEBUG_ONLY=1 BUILDTYPE=Debug BUILD_WITH=ninja make test-only
```
    @joyeecheung
    joyeecheung committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    02c6fc4 View commit details
    Browse the repository at this point in the history

  2. build: make DEBUG_ONLY work with make target

    @joyeecheung
    joyeecheung committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3bdf5ec View commit details
    Browse the repository at this point in the history

  3. fixup! build: make DEBUG_ONLY work with make target

    @joyeecheung
    joyeecheung committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c0d447d View commit details
    Browse the repository at this point in the history