Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: expand when we run internet tests #49218

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

mhdawson
Copy link
Member

Refs: #49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests.

Refs: nodejs#49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did
not run because no test under test/internet was changed.
Add some of the common paths that include code that might
introduce failures in the internet tests.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 17, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 18, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49218
✔  Done loading data for nodejs/node/pull/49218
----------------------------------- PR info ------------------------------------
Title      build: expand when we run internet tests (#49218)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:test-internet -> nodejs:main
Labels     meta, author ready
Commits    2
 - build: expand when we run internet tests
 - squash: make linter happy
Committers 2
 - Michael Dawson 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49218
Refs: https://github.com/nodejs/node/issues/49203
Reviewed-By: Ruy Adorno 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49218
Refs: https://github.com/nodejs/node/issues/49203
Reviewed-By: Ruy Adorno 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Moshe Atlow 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 17 Aug 2023 20:31:10 GMT
   ✔  Approvals: 5
   ✔  - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1583426778
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1583478858
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1584225277
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1585710027
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49218#pullrequestreview-1585716605
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49218
From https://github.com/nodejs/node
 * branch                  refs/pull/49218/merge -> FETCH_HEAD
✔  Fetched commits as 41a3a1daa28b..b855d5e9d24e
--------------------------------------------------------------------------------
[main f899b45376] build: expand when we run internet tests
 Author: Michael Dawson 
 Date: Thu Aug 17 16:17:22 2023 -0400
 1 file changed, 10 insertions(+), 2 deletions(-)
[main 9eb94b9abe] squash: make linter happy
 Author: Michael Dawson 
 Date: Thu Aug 17 16:43:37 2023 -0400
 1 file changed, 8 insertions(+), 8 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Refs: #49203, skipping..
--------------------------------- New Message ----------------------------------
build: expand when we run internet tests

Refs: #49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did
not run because no test under test/internet was changed.
Add some of the common paths that include code that might
introduce failures in the internet tests.

Signed-off-by: Michael Dawson [email protected]
PR-URL: #49218
Reviewed-By: Ruy Adorno [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 49e8ddcc49] build: expand when we run internet tests
Author: Michael Dawson [email protected]
Date: Thu Aug 17 16:17:22 2023 -0400
1 file changed, 10 insertions(+), 2 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
squash: make linter happy

PR-URL: #49218
Refs: #49203
Reviewed-By: Ruy Adorno [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD ea0d13c471] squash: make linter happy
Author: Michael Dawson [email protected]
Date: Thu Aug 17 16:43:37 2023 -0400
1 file changed, 8 insertions(+), 8 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5913403184

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5026293 into nodejs:main Aug 19, 2023
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5026293

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
Refs: #49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did
not run because no test under test/internet was changed.
Add some of the common paths that include code that might
introduce failures in the internet tests.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #49218
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
Refs: #49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did
not run because no test under test/internet was changed.
Add some of the common paths that include code that might
introduce failures in the internet tests.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #49218
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Refs: nodejs/node#49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did
not run because no test under test/internet was changed.
Add some of the common paths that include code that might
introduce failures in the internet tests.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs/node#49218
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Refs: nodejs/node#49203

Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did
not run because no test under test/internet was changed.
Add some of the common paths that include code that might
introduce failures in the internet tests.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs/node#49218
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants