build: expand when we run internet tests #49218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#49203 Changes slipped into v18.x regressed test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests. Signed-off-by: Michael Dawson <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
the
meta
ruyadorno
approved these changes
Aug 17, 2023
anonrig
approved these changes
Aug 17, 2023
aduh95
approved these changes
Aug 18, 2023
aduh95
added
author ready
MoLow
approved these changes
Aug 19, 2023
lpinca
approved these changes
Aug 19, 2023
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49218 ✔ Done loading data for nodejs/node/pull/49218 ----------------------------------- PR info ------------------------------------ Title build: expand when we run internet tests (#49218) Author Michael Dawson (@mhdawson) Branch mhdawson:test-internet -> nodejs:main Labels meta, author ready Commits 2 - build: expand when we run internet tests - squash: make linter happy Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/49218 Refs: https://github.com/nodejs/node/issues/49203 Reviewed-By: Ruy Adorno Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49218 Refs: https://github.com/nodejs/node/issues/49203 Reviewed-By: Ruy Adorno Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 17 Aug 2023 20:31:10 GMT ✔ Approvals: 5 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1583426778 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1583478858 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1584225277 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49218#pullrequestreview-1585710027 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49218#pullrequestreview-1585716605 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 49218 From https://github.com/nodejs/node * branch refs/pull/49218/merge -> FETCH_HEAD ✔ Fetched commits as 41a3a1daa28b..b855d5e9d24e -------------------------------------------------------------------------------- [main f899b45376] build: expand when we run internet tests Author: Michael Dawson Date: Thu Aug 17 16:17:22 2023 -0400 1 file changed, 10 insertions(+), 2 deletions(-) [main 9eb94b9abe] squash: make linter happy Author: Michael Dawson Date: Thu Aug 17 16:43:37 2023 -0400 1 file changed, 8 insertions(+), 8 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/5913403184 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5026293 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Refs: #49203 Changes slipped into v18.x regressed test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #49218 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Refs: #49203 Changes slipped into v18.x regressed test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #49218 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Refs: nodejs/node#49203 Changes slipped into v18.x regressed test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs/node#49218 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Refs: nodejs/node#49203 Changes slipped into v18.x regressed test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs/node#49218 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #49203
Changes slipped into v18.x regressed
test/internet/test-dns-ipv6 as I assume the action did not run because no test under test/internet was changed. Add some of the common paths that include code that might introduce failures in the internet tests.