typings: update JSDoc for cwd in child_process
#49029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
anonrig
approved these changes
Aug 5, 2023
lpinca
approved these changes
Aug 5, 2023
LiviaMedeiros
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49029 ✔ Done loading data for nodejs/node/pull/49029 ----------------------------------- PR info ------------------------------------ Title typings: update JSDoc for `cwd` in `child_process` (#49029) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:typings-cp-cwdurl -> nodejs:main Labels child_process, author ready, typings Commits 1 - typings: update JSDoc for `cwd` in `child_process` Committers 1 - LiviaMedeiros PR-URL: https://github.com/nodejs/node/pull/49029 Refs: https://github.com/nodejs/node/pull/38862 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49029 Refs: https://github.com/nodejs/node/pull/38862 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 05 Aug 2023 18:15:57 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49029#pullrequestreview-1563993533 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49029#pullrequestreview-1563996723 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5788551201 |
LiviaMedeiros
added a commit
that referenced
this pull request
Aug 8, 2023
PR-URL: #49029 Refs: #38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in aed2b21 |
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Aug 13, 2023
PR-URL: nodejs#49029 Refs: nodejs#38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#49029 Refs: nodejs#38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#49029 Refs: nodejs#38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #49029 Refs: #38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#49029 Refs: nodejs#38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
rluvaton
pushed a commit
to rluvaton/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#49029 Refs: nodejs#38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 17, 2023
PR-URL: #49029 Refs: #38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49029 Refs: #38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49029 Refs: nodejs/node#38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49029 Refs: nodejs/node#38862 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #38862