Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: allow updating to openssl 3.1.x #49001

Closed
wants to merge 1 commit into from

Conversation

kvakil
Copy link
Contributor

@kvakil kvakil commented Aug 3, 2023

The tag in the new updating script only matches OpenSSL 3.0 releases. There is now 3.1.2 release of OpenSSL-quic (see ref). Update the script to grab any 3.x release of OpenSSL.

Drive-by: update the help message.
Refs: https://github.com/quictls/openssl/tree/openssl-3.1.2+quic

The tag in the new updating script only matches OpenSSL 3.0 releases.
There is now 3.1.2 release of OpenSSL-quic (see ref). Update the script
to grab any 3.x release of OpenSSL.

Drive-by: update the help message.
Refs: https://github.com/quictls/openssl/tree/openssl-3.1.2+quic
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 3, 2023
@kvakil
Copy link
Contributor Author

kvakil commented Aug 3, 2023

@marco-ippolito: AFAICT this was changed in #48377. Just checking that it wasn't done intentionally for some reason.

@kvakil
Copy link
Contributor Author

kvakil commented Aug 3, 2023

Hm, I guess part of the issue here is that OpenSSL 3.1.x is not supported as long as OpenSSL 3.0:

Note: The latest stable version is the 3.1 series supported until 14th March 2025. Also available is the 3.0 series which is a Long Term Support (LTS) version and is supported until 7th September 2026.

from https://www.openssl.org/source/

An EOL of 14th March 2025 is before any of our current release line EOLs: https://github.com/nodejs/release#release-schedule

So I'm not sure. It's unfortunate, because there are user reports of issues with 3.0 which are fixed in 3.1, e.g. #43128.

@kvakil
Copy link
Contributor Author

kvakil commented Aug 3, 2023

Oops, already discussed here: #47177

Apologies for the noise :/

@kvakil kvakil closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants