Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid string copy in BuiltinLoader::GetBuiltinIds #48721

Merged
merged 1 commit into from
Aug 11, 2023
Merged

src: avoid string copy in BuiltinLoader::GetBuiltinIds #48721

merged 1 commit into from
Aug 11, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 10, 2023 •
edited
Loading

Replaces std::vector<std::string> with std::vector<std::string_view>

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 10, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52687/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52755/

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Jul 16, 2023
@anonrig
Copy link
Member Author

anonrig commented Jul 16, 2023

cc @nodejs/cpp-reviewers

@github-actions github-actions bot mentioned this pull request Jul 16, 2023
Open
23 tasks
@anonrig
Copy link
Member Author

anonrig commented Jul 16, 2023

It seems the error is unrelated: 00:00:02.442 tap2junit: error: argument --input/-i: can't open 'test.tap': [Errno 2] No such file or directory: 'test.tap'. I'll restart the CI.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52794/

This was referenced Jul 17, 2023
Open
Open
Open
Open
Open
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53155/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7ffa5d7 into nodejs:main Aug 11, 2023
6 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7ffa5d7

martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
@anonrig @martenrichter
src: avoid string copy in BuiltinLoader::GetBuiltinIds
e25d661 
PR-URL: nodejs#48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
src: avoid string copy in BuiltinLoader::GetBuiltinIds
cfb9f9d 
PR-URL: nodejs#48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
src: avoid string copy in BuiltinLoader::GetBuiltinIds
9ccaa19 
PR-URL: nodejs#48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@anonrig @RafaelGSS
src: avoid string copy in BuiltinLoader::GetBuiltinIds
22c7c80 
PR-URL: #48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@anonrig @RafaelGSS
src: avoid string copy in BuiltinLoader::GetBuiltinIds
f01224e 
PR-URL: nodejs#48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@anonrig @rluvaton
src: avoid string copy in BuiltinLoader::GetBuiltinIds
57ead55 
PR-URL: nodejs#48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
@anonrig @RafaelGSS
src: avoid string copy in BuiltinLoader::GetBuiltinIds
b966bea 
PR-URL: #48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@anonrig @RafaelGSS
src: avoid string copy in BuiltinLoader::GetBuiltinIds
db4370f 
PR-URL: #48721
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @lpinca @RafaelGSS @aduh95