Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update timezone to 2023c #48630

Closed
wants to merge 1 commit into from
Closed

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/timezone-update.yml.

Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#time-zone-data

To test, build node off this branch & log the version of tz using

console.log(process.versions.tz)

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 2, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@richardlau
Copy link
Member

ICU 73.2 should already have this version of timezone. We should update the updater scripts to only update if the version has changed.

@lpinca
Copy link
Member

lpinca commented Jul 12, 2023

I think we can close this then.

@lpinca lpinca closed this Jul 12, 2023
@lpinca lpinca deleted the actions/timezone-update branch July 12, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants