-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update create-or-update-pull-request-action #48398
Conversation
Use the same commit SHA for this action as used in our other workflows. Refs: #46169 Refs: #45022 (comment)
Review requested:
|
Workflow run with this PR: https://github.com/nodejs/node/actions/runs/5216284702/jobs/9414851477 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This workflow run opened #48399 which looks correct, except because I ran the workflow from the branch from this PR it included the commit from this PR in #48399. I'll close off #48399 and we can rerun the fixed workflow from the |
Fast-track has been requested by @bnoordhuis. Please 👍 to approve. |
Landed in 6a3403c |
Use the same commit SHA for this action as used in our other workflows. Refs: #46169 Refs: #45022 (comment) PR-URL: #48398 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Use the same commit SHA for this action as used in our other workflows. Refs: nodejs#46169 Refs: nodejs#45022 (comment) PR-URL: nodejs#48398 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Use the same commit SHA for this action as used in our other workflows. Refs: nodejs#46169 Refs: nodejs#45022 (comment) PR-URL: nodejs#48398 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Use the same commit SHA for this action as used in our other workflows. Refs: #46169 Refs: #45022 (comment) PR-URL: #48398 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Use the same commit SHA for this action as used in our other workflows. Refs: #46169 Refs: #45022 (comment) PR-URL: #48398 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Use the same commit SHA for this action as used in our other workflows.
Refs: #46169
Refs: #45022 (comment)
The workflow is currently failing: https://github.com/nodejs/node/actions/runs/5215729249/jobs/9413680952