-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: run license-builder #48336
doc: run license-builder #48336
Conversation
Review requested:
|
Pinging @fasenderos since they are the one who drove the zlib upgrade changes, and the diff looks a bit weird. |
@aduh95 I'll take a look |
The changes of this PR reflect the Chromium's copy of zlib that we use (we don't use the official zlib library): |
More specifically, the license header was changed in https://chromium.googlesource.com/chromium/src/+/f103edb8dc89fd780cd374ca34707617f49d0303%5E%21/#F10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM defintely hard to line up with what is obvious from the contents under deps but seem to be the right value from the patch @targos linked to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking it @fasenderos @targos. LGTM.
Landed in f100732 |
PR-URL: #48336 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#48336 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#48336 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #48336 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
License is likely out of date. This is an automatically generated PR by the
license-builder.yml
GitHub Action, which runslicense-builder.sh
and submits a new PR or updates an existing PR.