Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing <algorithm> include for std::find #48330

Closed
wants to merge 1 commit into from
Closed

test: add missing <algorithm> include for std::find #48330

wants to merge 1 commit into from

Conversation

thesamesam
Copy link
Contributor

GCC 14 drops some transitive includes within libstdc++. Explicitly include for std::find.

Signed-off-by: Sam James [email protected]

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 4, 2023
@thesamesam
test: add missing <algorithm> include for std::find
bf0e64d 
GCC 14 drops some transitive includes within libstdc++.

Explicitly include <algorithm> for std::find.

Signed-off-by: Sam James <[email protected]>
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52082/

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Fast-track has been requested by @targos. Please 👍 to approve.

@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Open
30 tasks
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Open
20 tasks
@thesamesam thesamesam closed this by deleting the head repository Jun 7, 2023
@thesamesam thesamesam mentioned this pull request Jun 7, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@marsonya marsonya marsonya approved these changes

@debadree25 debadree25 debadree25 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@thesamesam @nodejs-github-bot @lpinca @anonrig @targos @cjihrig @tniessen @marsonya @debadree25 @RaisinTen