test: fix flaky test-watch-mode #48147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
MoLow
added
the
flaky-test
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
5 times, most recently
from
fee6ffb
to
155d3a0
Compare
github-actions
bot
removed
the
request-ci
This was referenced May 26, 2023
This was referenced Jun 2, 2023
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
from
155d3a0
to
3dfe3ce
Compare
github-actions
bot
removed
the
request-ci
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
3 times, most recently
from
c968d3d
to
d68b680
Compare
MoLow
force-pushed
the
fix-flaky-test-watch-mode
branch
from
d68b680
to
078afb8
Compare
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Jun 8, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9dc2d1b |
This was referenced Jun 11, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48147 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
hi @MoLow this is not landing cleanly in |
ruyadorno
added
the
backport-requested-v18.x
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Sep 3, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Sep 3, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow
added
backport-open-v18.x
ruyadorno
pushed a commit
to MoLow/node
that referenced
this pull request
Sep 7, 2023
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 7, 2023
PR-URL: #48147 Backport-PR-URL: #49468 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
ruyadorno
added
backported-to-v18.x
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
PR-URL: #48147 Backport-PR-URL: #49468 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44898
stress tests: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/402/
also, ran
python tools/test.py -J --repeat=500 test/sequential/test-watch-modelocally (macos m1 & windows vm with arm) with no failures