Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: proper markdown escaping -> \_\_, \*, \_ #4805

Closed
wants to merge 1 commit into from
Closed

doc: proper markdown escaping -> \_\_, \*, \_ #4805

wants to merge 1 commit into from

Conversation

eljefedelrodeodeljefe
Copy link
Contributor

Continuation of #4733:

Fixes wrong escaping.
Now more pleasant Editor experience.

Rendered HTML looked same to me.

eingefugtes_bild_21_01_16__22_43

@silverwind silverwind added the doc Issues and PRs related to the documentations. label Jan 21, 2016
@jasnell
Copy link
Member

jasnell commented Jan 21, 2016

LGTM

more data from the resource and pushing that data onto the queue.

Note: once the `_read()` method is called, it will not be called again until
Note: once the `\_read()` method is called, it will not be called again until
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the issue still happen in the code blocks? I'm not sure about the website but this looks different on GH's rendering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. This one slipped: stays _read(). Will push in a bit. Thx

@jasnell
Copy link
Member

jasnell commented Jan 23, 2016

@nodejs/documentation

@Qard
Copy link
Member

Qard commented Jan 23, 2016

LGTM

@Knighton910
Copy link

👍

@thefourtheye
Copy link
Contributor

Awesome :-) I used to think if this can be fixed. LGTM.

jasnell pushed a commit that referenced this pull request Jan 23, 2016
PR-URL: #4805
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 23, 2016

Landed in 17d5a3a :-)

@jasnell jasnell closed this Jan 23, 2016
@eljefedelrodeodeljefe eljefedelrodeodeljefe deleted the feature/doc-escaping-fixes branch January 23, 2016 12:11
rvagg pushed a commit that referenced this pull request Jan 25, 2016
PR-URL: #4805
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
PR-URL: #4805
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4805
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #4805
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4805
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants