Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix setting path containing an ampersand #4804

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 21, 2016

This commit fixes an issue with the Node.js command prompt on Windows where the PATH environment variable would not be set correctly if the existing PATH contained an '&'.

Fixes: #4802

This commit fixes an issue with the Node.js command prompt
on Windows where the PATH environment variable would not be
set correctly if the existing PATH contained an '&'.

Fixes: nodejs#4802
@mscdex mscdex added windows Issues and PRs related to the Windows platform. tools Issues and PRs related to the tools directory. labels Jan 21, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jan 21, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jan 21, 2016

LGTM

mscdex added a commit that referenced this pull request Jan 23, 2016
This commit fixes an issue with the Node.js command prompt
on Windows where the PATH environment variable would not be
set correctly if the existing PATH contained an '&'.

Fixes: #4802
PR-URL: #4804
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mscdex
Copy link
Contributor Author

mscdex commented Jan 23, 2016

Landed in 922d538.

@mscdex mscdex closed this Jan 23, 2016
@mscdex mscdex deleted the fix-windows-nodevars-path branch January 23, 2016 09:10
rvagg pushed a commit that referenced this pull request Jan 25, 2016
This commit fixes an issue with the Node.js command prompt
on Windows where the PATH environment variable would not be
set correctly if the existing PATH contained an '&'.

Fixes: #4802
PR-URL: #4804
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
This commit fixes an issue with the Node.js command prompt
on Windows where the PATH environment variable would not be
set correctly if the existing PATH contained an '&'.

Fixes: #4802
PR-URL: #4804
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
This commit fixes an issue with the Node.js command prompt
on Windows where the PATH environment variable would not be
set correctly if the existing PATH contained an '&'.

Fixes: #4802
PR-URL: #4804
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
This commit fixes an issue with the Node.js command prompt
on Windows where the PATH environment variable would not be
set correctly if the existing PATH contained an '&'.

Fixes: #4802
PR-URL: #4804
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
This commit fixes an issue with the Node.js command prompt
on Windows where the PATH environment variable would not be
set correctly if the existing PATH contained an '&'.

Fixes: nodejs#4802
PR-URL: nodejs#4804
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Copy link

@IR4N0nY IR4N0nY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi
unfortunately i have and & in my username in windows and appdata path in my system is =
c:\users\s&a....
when i want to run ng upate on my app or any other app they give me an error like this:

Installing packages for tooling via npm.
Error: EPERM: operation not permitted, mkdir 'C:\Users\s'
The system cannot find the path specified.
An unhandled exception occurred: Package install failed, see above.
See "C:\Users\s&a\AppData\Local\Temp\ng-3iALVs\angular-errors.log" for further details.

and cant update ro install any thing
my node version = 14.3.0
is there any suggestion to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

win: Node.js command prompt fails to set PATH with unescaped & in it
5 participants