-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner: display dot report as wide as the terminal width #48038
Merged
nodejs-github-bot
merged 6 commits into
nodejs:main
from
rluvaton:display-dot-test-report-as-wide-as-the-terminal
May 23, 2023
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c324ad8
test_runner: display dot report as wide as the terminal width
rluvaton b47e380
test_runner: add test and fix error
rluvaton ae1906c
Update lib/internal/test_runner/reporter/dot.js
rluvaton b991fd2
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
rluvaton d38e661
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
rluvaton ef8cec7
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
rluvaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,27 @@ | ||
'use strict'; | ||
const { MathMax } = primordials; | ||
|
||
module.exports = async function* dot(source) { | ||
let count = 0; | ||
let columns = getLineLength(); | ||
for await (const { type } of source) { | ||
if (type === 'test:pass') { | ||
yield '.'; | ||
} | ||
if (type === 'test:fail') { | ||
yield 'X'; | ||
} | ||
if ((type === 'test:fail' || type === 'test:pass') && ++count % 20 === 0) { | ||
if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) { | ||
yield '\n'; | ||
|
||
// Getting again in case the terminal was resized. | ||
columns = getLineLength(); | ||
count = 0; | ||
} | ||
} | ||
yield '\n'; | ||
}; | ||
|
||
function getLineLength() { | ||
return MathMax(process.stdout.columns ?? 20, 20); | ||
} |
18 changes: 18 additions & 0 deletions
18
test/fixtures/test-runner/output/dot_output_custom_columns.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Flags: --test-reporter=dot | ||
'use strict'; | ||
process.stdout.columns = 30; | ||
|
||
const test = require('node:test'); | ||
const {setTimeout} = require('timers/promises'); | ||
rluvaton marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
for (let i = 0; i < 100; i++) { | ||
test(i + ' example', async () => { | ||
if(i === 0) { | ||
rluvaton marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// So the reporter will run before all tests has started | ||
await setTimeout(10); | ||
} | ||
// resize | ||
if (i === 28) | ||
process.stdout.columns = 41; | ||
}); | ||
} |
3 changes: 3 additions & 0 deletions
3
test/fixtures/test-runner/output/dot_output_custom_columns.snapshot
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.............................. | ||
......................................... | ||
............................. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the
++count === columns
be nested inside of the top levelif
? That way we only need to callgetLineLength()
once from there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need to call again is in case of resize of the terminal