benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` #48002

deokjinkim · 2023-05-14T13:59:40Z

cluster.isMaster was deprecated. So need to use cluster.isPrimary for benchmark.

tniessen

In benchmarks, this makes sense. In tests, there are already various occurrences of isPrimary, and removing all usages of the old APIs means that they won't be covered by tests anymore. We should still be testing deprecated APIs until they are removed.

`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: nodejs#47981

deokjinkim · 2023-05-14T14:57:48Z

In benchmarks, this makes sense. In tests, there are already various occurrences of isPrimary, and removing all usages of the old APIs means that they won't be covered by tests anymore. We should still be testing deprecated APIs until they are removed.

I agree with you. So revert changed code for test. Thank you for kind review!

nodejs-github-bot · 2023-05-15T13:01:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51817/

nodejs-github-bot · 2023-05-16T14:04:27Z

Commit Queue failed

- Loading data for nodejs/node/pull/48002
✔  Done loading data for nodejs/node/pull/48002
----------------------------------- PR info ------------------------------------
Title      benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` (#48002)
Author     Deokjin Kim  (@deokjinkim)
Branch     deokjinkim:230514_benchmark_use_cluster_isprimary -> nodejs:main
Labels     cluster, benchmark, author ready, needs-ci
Commits    1
 - benchmark: use `cluster.isPrimary` instead of `cluster.isMaster`
Committers 1
 - Deokjin Kim 
PR-URL: https://github.com/nodejs/node/pull/48002
Refs: https://github.com/nodejs/node/pull/47981
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48002
Refs: https://github.com/nodejs/node/pull/47981
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 14 May 2023 13:59:40 GMT
   ✔  Approvals: 3
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425560993
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425565383
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48002#pullrequestreview-1427261292
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-05-15T13:01:01Z: https://ci.nodejs.org/job/node-test-pull-request/51817/
- Querying data for job/node-test-pull-request/51817/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4992884399

nodejs-github-bot · 2023-05-17T01:27:09Z

Commit Queue failed

- Loading data for nodejs/node/pull/48002
✔  Done loading data for nodejs/node/pull/48002
----------------------------------- PR info ------------------------------------
Title      benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` (#48002)
Author     Deokjin Kim  (@deokjinkim)
Branch     deokjinkim:230514_benchmark_use_cluster_isprimary -> nodejs:main
Labels     cluster, benchmark, author ready, needs-ci
Commits    1
 - benchmark: use `cluster.isPrimary` instead of `cluster.isMaster`
Committers 1
 - Deokjin Kim 
PR-URL: https://github.com/nodejs/node/pull/48002
Refs: https://github.com/nodejs/node/pull/47981
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48002
Refs: https://github.com/nodejs/node/pull/47981
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 14 May 2023 13:59:40 GMT
   ✔  Approvals: 3
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425560993
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425565383
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48002#pullrequestreview-1427261292
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-05-16T14:04:27Z: https://ci.nodejs.org/job/node-test-pull-request/51817/
- Querying data for job/node-test-pull-request/51817/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4998309251

nodejs-github-bot · 2023-05-17T05:51:55Z

Landed in ca09656

`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: #47981 PR-URL: #48002 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: nodejs#47981 PR-URL: nodejs#48002 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. cluster Issues and PRs related to the cluster subsystem. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 14, 2023

MoLow approved these changes May 14, 2023

View reviewed changes

tniessen reviewed May 14, 2023

View reviewed changes

benchmark: use cluster.isPrimary instead of cluster.isMaster

fab804c

`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: nodejs#47981

deokjinkim force-pushed the 230514_benchmark_use_cluster_isprimary branch from 7fa0309 to fab804c Compare May 14, 2023 14:55

deokjinkim changed the title ~~benchmark,test: use cluster.isPrimary instead of cluster.isMaster~~ benchmark: use cluster.isPrimary instead of cluster.isMaster May 14, 2023

tniessen approved these changes May 14, 2023

View reviewed changes

deokjinkim marked this pull request as draft May 15, 2023 00:29

deokjinkim marked this pull request as ready for review May 15, 2023 00:30

deokjinkim added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels May 15, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2023

This comment was marked as outdated.

Sign in to view

deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2023

lpinca approved these changes May 15, 2023

View reviewed changes

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 16, 2023

deokjinkim added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 17, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 17, 2023

deokjinkim added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 17, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2023

nodejs-github-bot merged commit ca09656 into nodejs:main May 17, 2023

targos mentioned this pull request Jun 4, 2023

v20.3.0 release proposal #48332

Merged

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` #48002

benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` #48002

deokjinkim commented May 14, 2023 •

edited

Loading

tniessen left a comment

deokjinkim commented May 14, 2023

This comment was marked as outdated.

nodejs-github-bot commented May 15, 2023

nodejs-github-bot commented May 16, 2023

nodejs-github-bot commented May 17, 2023

nodejs-github-bot commented May 17, 2023

benchmark: use cluster.isPrimary instead of cluster.isMaster #48002

benchmark: use cluster.isPrimary instead of cluster.isMaster #48002

Conversation

deokjinkim commented May 14, 2023 • edited Loading

tniessen left a comment

Choose a reason for hiding this comment

deokjinkim commented May 14, 2023

This comment was marked as outdated.

nodejs-github-bot commented May 15, 2023

nodejs-github-bot commented May 16, 2023

nodejs-github-bot commented May 17, 2023

nodejs-github-bot commented May 17, 2023

benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` #48002

benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` #48002

deokjinkim commented May 14, 2023 •

edited

Loading