Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-net-settimeout #4799

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 21, 2016

test-net-settimeout is unnecessarily complex. This change simplifies it.

test-net-settimeout is unnecessarily complex. This change simplifies it.
@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Jan 21, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 21, 2016

@jbergstroem
Copy link
Member

☝️ What he said, LGTM

@Trott
Copy link
Member Author

Trott commented Jan 24, 2016

CI looks good in that failures are a known flaky test (that has since been removed) and a bunch of buildbot problems. Let's try again to see if we get something a little cleaner:

https://ci.nodejs.org/job/node-test-pull-request/1359/

@Trott
Copy link
Member Author

Trott commented Jan 25, 2016

Irksomely, the only failure was a Windows buildbot failure that just happened to be one of the ones that would run this settimeout test. Trying a third CI because that is what I do: https://ci.nodejs.org/job/node-test-pull-request/1366/

@Trott
Copy link
Member Author

Trott commented Jan 26, 2016

Last CI buildbot failures were on fanned machines not slated to run this test, so we're all set.

Trott added a commit to Trott/io.js that referenced this pull request Jan 26, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: nodejs#4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jan 26, 2016

Landed in 457a1ca

@Trott Trott closed this Jan 26, 2016
rvagg pushed a commit that referenced this pull request Jan 27, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: #4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: nodejs#4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 8, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: #4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: #4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: #4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: #4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test-net-settimeout is unnecessarily complex. This change simplifies it.

PR-URL: nodejs#4799
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@Trott Trott deleted the settimeout branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants