Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: display dot report as wide as the terminal width #47901

Closed
wants to merge 4 commits into from
Closed

test: display dot report as wide as the terminal width #47901

wants to merge 4 commits into from

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented May 6, 2023 •
edited
Loading

How would you suggest I add a test for this?, I'm trying to avoid overridden process.stdout.columns

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 6, 2023
@MoLow
Copy link
Member

MoLow commented May 7, 2023

commit messages prefix should be test_runner:, not test:, besides that - maybe add a pseudo-tty test?

@rluvaton rluvaton mentioned this pull request May 16, 2023
Merged
@rluvaton
Copy link
Member Author

Closed in favor of #48038

@rluvaton rluvaton closed this May 16, 2023
@rluvaton rluvaton deleted the display-dot-as-wide-as-the-terminal branch May 16, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rluvaton @nodejs-github-bot @MoLow