Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate a pseudo_tty test to use assertSnapshot #47803

Merged
merged 2 commits into from
May 4, 2023
Merged

test: migrate a pseudo_tty test to use assertSnapshot #47803

merged 2 commits into from
May 4, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented May 1, 2023

this is another followup for #47498 enabling running pseudo-tty snapshot tests

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@MoLow MoLow marked this pull request as draft May 1, 2023 18:01
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 1, 2023
@MoLow MoLow mentioned this pull request May 1, 2023
Closed
@MoLow MoLow marked this pull request as ready for review May 1, 2023 20:06
GeoffreyBooth
GeoffreyBooth approved these changes May 1, 2023
View reviewed changes
test/common/assertSnapshot.js Outdated Show resolved Hide resolved
test/fixtures/test-runner/output/default_output.snapshot
@@ -0,0 +1,57 @@
[32m✔ should pass [90m(*ms)[39m[39m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run these with ANSI colors support disabled to make easier-to-read snapshots?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire purpose of this test is to test the colors and the reporter

test/parallel/test-runner-output.mjs Outdated Show resolved Hide resolved
@MoLow MoLow force-pushed the migrate-psuedo-tty branch 2 times, most recently from b6f9dfd to 12913f5 Compare May 2, 2023 05:21
@MoLow MoLow changed the title test: migrate pseudo_tty tests to use assertSnapshot test: migrate a pseudo_tty test to use assertSnapshot May 2, 2023
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51569/

@github-actions github-actions bot mentioned this pull request May 3, 2023
Open
33 tasks
@MoLow
Copy link
Member Author

MoLow commented May 3, 2023

I spend hours to get a working Windows environment to figure out why tests were failing when it turns out this is the original behavior 😂 :

node/test/pseudo-tty/testcfg.py

Lines 143 to 145 in 76ae7be

if utils.IsWindows():
print ("Skipping pseudo-tty tests, as pseudo terminals are not available"
" on Windows.")

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51616/

@github-actions github-actions bot mentioned this pull request May 4, 2023
Open
28 tasks
@benjamingr benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9e5e2f1 into nodejs:main May 4, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9e5e2f1

@MoLow MoLow deleted the migrate-psuedo-tty branch May 4, 2023 08:57
@github-actions github-actions bot mentioned this pull request May 5, 2023
Open
22 tasks
targos pushed a commit that referenced this pull request May 12, 2023
@MoLow @targos
test: migrate a pseudo_tty test to use assertSnapshot
17945a2 
PR-URL: #47803
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test: migrate a pseudo_tty test to use assertSnapshot
afb85df 
PR-URL: #47803
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test: migrate a pseudo_tty test to use assertSnapshot
95972aa 
PR-URL: nodejs#47803
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@benjamingr benjamingr benjamingr approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoLow @nodejs-github-bot @ljharb @GeoffreyBooth @benjamingr