buffer: make File cloneable #47613

KhafraDev · 2023-04-19T01:16:19Z

KhafraDev · 2023-04-19T01:20:57Z

Since I had to move back to using symbols instead of private properties for brand checking, the error for invalid this has changed, so I'm marking it as semver-major.

lib/internal/file.js

KhafraDev · 2023-04-22T01:31:56Z

cc @anonrig @aduh95 @nodejs/buffer

nodejs-github-bot · 2023-04-22T01:33:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51403/

anonrig

I still think we should find an elegant solution to this issue, and not revert to using symbols.

aduh95 · 2023-04-22T09:25:26Z

I still think we should find an elegant solution to this issue, and not revert to using symbols.

Would you really prefer that the File objects are never made cloneable, hurting web compat? I don't think it's fair to block this PR on an implementation detail (especially when it was already addressed in #47613 (comment)), if you feel strongly about this, you should open a concurrent PR, or propose a working solution.

aduh95

LGTM, I gave it a go and try to use private fields, I didn't manage to get anything working, using a Symbol seems the correct option for now.

I'm not sure it's actually a semver-major change, as it's still going to be a TypeError, we're adding a code property not modifying it, and the error message is not covered by semver rules in our policy.

Can you add an entry in the history section to track what version has cloneable File implementation?

node/doc/api/buffer.md

Lines 5065 to 5074 in eb17645

    
           ## Class: `File` 
        
           <!-- YAML 
        
           added: 
        
             - v19.2.0 
        
             - v18.13.0 
        
           changes: 
        
             - version: v20.0.0 
        
               pr-url: https://github.com/nodejs/node/pull/47153 
        
               description: No longer experimental.

test/parallel/test-file.js

anonrig · 2023-04-22T21:58:03Z

Would you really prefer that the File objects are never made cloneable, hurting web compat? I don't think it's fair to block this PR on an implementation detail (especially when it was already addressed in #47613 (comment)), if you feel strongly about this, you should open a concurrent PR, or propose a working solution.

@aduh95 I agree and share your concerns, and I am, too, interested in a web-compatible File class, but unfortunately, this pull request didn't receive any attention from people who have more in depth knowledge on this, and I prefer to wait for them to look into it (This is my main reason for blocking this pull request). The decision to revert and use Symbols affect all classes inside the Node project. Whether or not we are using private properties, by such limitations, should be at least discussed with people who initially implemented them in case we are missing something here. Unfortunately, I don't know the correct person to tag this, and I kindly ask for your help reaching out to them.

Unfortunately, I can't look into this issue in the next few days, but I'll try to look as soon as possible. If you think we should proceed with the current approach or in a time-sensitive manner, we can always add tsc-agenda, which will create a way for TSC to discuss the approach and might help us find a common ground here.

aduh95 · 2023-04-22T22:48:30Z

@anonrig here's what the collaborator guide says about objections:

node/doc/contributing/collaborator-guide.md

Lines 153 to 156 in 6c76d7e

    
           objection. Any pull request objection must include a clear reason for that 
        
           objection, and the objector must remain responsive for further discussion 
        
           towards consensus about the direction of the pull request. Where possible, 
        
           provide a set of actionable steps alongside the objection.

If you plan on being irresponsive in the following days, blocking that PR is really not a good timing.

The decision to revert and use Symbols affect all classes inside the Node project.

That's simply not true, this PR only changes the File class, there's no reason other parts of the codebase would be affected.

Whether or not we are using private properties, by such limitations, should be at least discussed with people who initially implemented them in case we are missing something here

Fair enough, that's not a reason for blocking the PR though, and Khafra did ping the buffer team already. If this PR lands, that doesn't mean the implementation will be frozen, someone can open a follow up PR.

IMO getting closer to web compat is more important for our users than the symbol vs private fields debate that have no effect for them; if you disagree that's fine of course but then please say so explicitly, it's always better to have thorough requests for change.

Dismissing due to being unavailable in the next couple of days and respecting the collaborator guide.

Trott · 2023-04-22T23:04:08Z

FWIW, something I sometimes do is leave a request-for-changes with a comment saying something like "Once X and Y happen, feel free to dismiss this request-for-change. You don't need to ping me or anything."

nodejs-github-bot · 2023-04-23T16:49:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51432/

Trott · 2023-04-23T20:21:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51432/

@KhafraDev Longstanding annoyance with our CI is that it does not handle merge commits well. Can you rebase/force-push to this branch to get rid of the merge commit?

KhafraDev · 2023-04-23T20:37:38Z

Thanks! Will keep that in mind for the future :)

nodejs-github-bot · 2023-04-23T20:50:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51439/

aduh95 · 2023-09-29T10:24:07Z

@nodejs/tsc since this is semver-major

nodejs-github-bot · 2023-09-29T10:25:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54357/

KhafraDev · 2024-09-25T19:26:10Z

Even after a year, there doesn't seem to be a way to use private properties.

codecov · 2024-09-25T21:09:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (aac8ba7) to head (00fd459).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #47613      +/-   ##
==========================================
- Coverage   88.24%   88.24%   -0.01%     
==========================================
  Files         651      651              
  Lines      183856   183907      +51     
  Branches    35853    35864      +11     
==========================================
+ Hits       162251   162286      +35     
- Misses      14896    14907      +11     
- Partials     6709     6714       +5

Files with missing lines	Coverage Δ
lib/internal/blob.js	`99.80% <100.00%> (+<0.01%)`	⬆️
lib/internal/file.js	`97.35% <100.00%> (+1.31%)`	⬆️

... and 30 files with indirect coverage changes

nodejs-github-bot · 2024-09-25T21:18:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62771/

nodejs-github-bot · 2024-09-26T00:58:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62774/

nodejs-github-bot · 2024-09-26T05:00:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62779/

mcollina

lgtm

mcollina

lgtm

nodejs-github-bot · 2024-09-26T08:24:41Z

Landed in 17fd327

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: TBD

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495 buffer: * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588 * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077 * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077 * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081 * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079 * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184 * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427 child_process: * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793 cli: * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761 * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747 * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723 * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611 * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564 crypto: * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019 * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305 * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552 deps: * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536 * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536 * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536 * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536 * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077 * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077 doc: * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967 * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338 esm: * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848 events: * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889 fs: * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741 * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050 lib: * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965 * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965 * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355 net: * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470 path: * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224 process: * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536 * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077 * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077 * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077 * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174 * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347 stream: * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241 string_decoder: * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957 test: * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077 test_runner: * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881 * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548 * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403 timers: * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678 tls: * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627 tools: * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536 * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077 * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077 util: * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744 * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744 zlib: * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020 PR-URL: #55338

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 19, 2023

KhafraDev added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 19, 2023

anonrig reviewed Apr 19, 2023

View reviewed changes

lib/internal/file.js Outdated Show resolved Hide resolved

anonrig previously requested changes Apr 22, 2023

View reviewed changes

aduh95 approved these changes Apr 22, 2023

View reviewed changes

test/parallel/test-file.js Outdated Show resolved Hide resolved

nodejs deleted a comment from nodejs-github-bot Apr 22, 2023

KhafraDev force-pushed the file-cloneable branch from ad4d427 to 3d386a5 Compare April 23, 2023 20:35

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2023

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

anonrig approved these changes Sep 25, 2024

View reviewed changes

fixup! use FileState class

00fd459

aduh95 approved these changes Sep 25, 2024

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 25, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2024

RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 25, 2024

mcollina approved these changes Sep 26, 2024

View reviewed changes

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2024

nodejs-github-bot merged commit 17fd327 into nodejs:main Sep 26, 2024
61 checks passed

KhafraDev deleted the file-cloneable branch September 26, 2024 13:50

RedYetiDev mentioned this pull request Sep 26, 2024

buffer: correctly apply prototype to cloned File / Blob #55138

Merged

azangru mentioned this pull request Oct 4, 2024

File support dumbmatter/fakeIndexedDB#102

Open

RafaelGSS mentioned this pull request Oct 9, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buffer: make File cloneable #47613

buffer: make File cloneable #47613

KhafraDev commented Apr 19, 2023

KhafraDev commented Apr 19, 2023

KhafraDev commented Apr 22, 2023

nodejs-github-bot commented Apr 22, 2023

anonrig left a comment

aduh95 commented Apr 22, 2023

aduh95 left a comment

anonrig commented Apr 22, 2023

aduh95 commented Apr 22, 2023 •

edited

Loading

Trott commented Apr 22, 2023

nodejs-github-bot commented Apr 23, 2023

Trott commented Apr 23, 2023 •

edited

Loading

KhafraDev commented Apr 23, 2023

nodejs-github-bot commented Apr 23, 2023

aduh95 commented Sep 29, 2023

nodejs-github-bot commented Sep 29, 2023

KhafraDev commented Sep 25, 2024

codecov bot commented Sep 25, 2024 •

edited

Loading

nodejs-github-bot commented Sep 25, 2024

nodejs-github-bot commented Sep 26, 2024

nodejs-github-bot commented Sep 26, 2024

mcollina left a comment

mcollina left a comment

nodejs-github-bot commented Sep 26, 2024

	## Class: `File`

	<!-- YAML
	added:
	- v19.2.0
	- v18.13.0
	changes:
	- version: v20.0.0
	pr-url: https://github.com/nodejs/node/pull/47153
	description: No longer experimental.

buffer: make File cloneable #47613

buffer: make File cloneable #47613

Conversation

KhafraDev commented Apr 19, 2023

KhafraDev commented Apr 19, 2023

KhafraDev commented Apr 22, 2023

nodejs-github-bot commented Apr 22, 2023

anonrig left a comment

Choose a reason for hiding this comment

aduh95 commented Apr 22, 2023

aduh95 left a comment

Choose a reason for hiding this comment

anonrig commented Apr 22, 2023

aduh95 commented Apr 22, 2023 • edited Loading

Trott commented Apr 22, 2023

nodejs-github-bot commented Apr 23, 2023

Trott commented Apr 23, 2023 • edited Loading

KhafraDev commented Apr 23, 2023

nodejs-github-bot commented Apr 23, 2023

aduh95 commented Sep 29, 2023

nodejs-github-bot commented Sep 29, 2023

KhafraDev commented Sep 25, 2024

codecov bot commented Sep 25, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Sep 25, 2024

nodejs-github-bot commented Sep 26, 2024

nodejs-github-bot commented Sep 26, 2024

mcollina left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 26, 2024

aduh95 commented Apr 22, 2023 •

edited

Loading

Trott commented Apr 23, 2023 •

edited

Loading

codecov bot commented Sep 25, 2024 •

edited

Loading