Fix concurrent sparkplug #47461
Closed
Fix concurrent sparkplug #47461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
[heap] Cache ForegroundTaskRunner in CollectionBarrier
The API doesn't allow us to invoke GetForegroundTaskRunner() from
a background thread. We need to cache the task runner in the ctor
of CollectionBarrier during heap setup.
We can't create the CollectionBarrier inside Heap's ctor anymore
because at that point the TaskRunner might not be set up (e.g. Node).
Bug: v8:13902
Change-Id: I814b9dbecb0ded673108bfb7b730e7c9338cf5f5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4403395
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Dominik Inführ <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86981}
Refs: v8/v8@8f61b41
Original commit message:
[heap] Cache GetForegroundTaskRunner in IncrementalMarkingJob
Our API doesn't allow us to invoke GetForegroundTaskRunner() from
a background thread. We need to cache the task runner in the ctor
of IncrementalMarkingJob during heap setup.
This is necessary because we may start incremental marking from
background threads.
Bug: v8:13902
Change-Id: I938c9bf016e05145f1807c27fd477a7b6c859ca4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4405689
Commit-Queue: Dominik Inführ <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86983}
Refs: v8/v8@f820e70
|
Review requested:
|
nodejs-github-bot
added
lib / src
targos
added
dont-land-on-v14.x
dont-land-on-v18.x
github-actions
bot
removed
the
request-ci
targos
force-pushed
the
fix-concurrent-sparkplug
branch
from
d61b80d
to
81b1a41
Compare
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying #47450 (comment)
/cc @miladfarca @dinfuehr