crypto: use openssl's own memory BIOs in crypto_context.cc #47160

GauriSpears · 2023-03-19T09:22:51Z

NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys. So I switched to OpenSSL's own protected memory bu ffers.

Fixes: #47008

nodejs-github-bot · 2023-03-19T09:22:55Z

Review requested:

@nodejs/crypto

src/crypto/crypto_context.cc

GauriSpears · 2023-03-19T15:51:52Z

There was an error requiring running CLANG_FORMAT_START=$(git merge-base HEAD main) make format-cpp
I ran the command and re-commited everything. Hope it will help,

GauriSpears · 2023-03-20T10:13:16Z

Please help! I ran the CLANG_FORMAT_START=$(git merge-base HEAD main) make format-cpp several times and updated commits, but I got the Linters / format-cpp error again. What should I do?

src/crypto/crypto_context.cc

GauriSpears · 2023-03-20T10:38:42Z

Oh, thanks a lot!

addaleax · 2023-03-20T16:04:18Z

This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys.

Is it possible to add a test for this? That feels necessary for a change like this (otherwise a future PR that undoes these changes with the goal of simplifying code probably also has a good chance of being approved).

GauriSpears · 2023-03-20T17:15:38Z

This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys.

Is it possible to add a test for this? That feels necessary for a change like this (otherwise a future PR that undoes these changes with the goal of simplifying code probably also has a good chance of being approved).

I can give you a test key but you have to install gost-engine (additional OpenSSL engine) to check it...
Maybe we should test that BIO created with LoadBIO must support BIO_seek?

GauriSpears · 2023-03-21T04:01:05Z

I've tried environment without gost-engine installed and found that I can't make TLS connection but I can create secure context with my key (it fails without my patch and successes with it). So I'll try to write a test.

GauriSpears · 2023-03-21T04:02:57Z

By the way, what is a reason to statically link OpenSSL during Node.JS compilation by default? I mean that's somehow weird that in the rest of platform you can load any openssl config with --openssl-config option, load any engine with crypto.setEngine, but, for example, tls part is statically linked to a certain OpenSSL.

bnoordhuis · 2023-03-21T10:37:33Z

If you've ever tried to ship a dynamically linked binary across a multitude of platforms and distros, you know the answer. ^_^

GauriSpears · 2023-03-22T04:25:26Z

This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys.

Is it possible to add a test for this? That feels necessary for a change like this (otherwise a future PR that undoes these changes with the goal of simplifying code probably also has a good chance of being approved).

Done.

GauriSpears · 2023-03-22T04:30:06Z

If you've ever tried to ship a dynamically linked binary across a multitude of platforms and distros, you know the answer. ^_^

I just wonder why statically linked Node.JS does support engines in crypto.createSign but not in tls.connect.

bnoordhuis · 2023-03-22T07:56:48Z

It does. Not sure where you get that notion from but clientCertEngine etc. work in both statically and dynamically linked builds.

GauriSpears · 2023-03-22T08:22:10Z

Haha) tls.getCiphers() doesn't see additional ciphers until OpenSSL is dynamically linked, Looks like there will be another investigation and another issue))

bnoordhuis · 2023-03-22T08:36:11Z

Oh, is that what you mean. That's indeed a separate issue but the reason is simple: SSL_get_ciphers() is called once and the result is cached. If you call it before your engine is loaded, you won't see any of the new ciphers it adds.

GauriSpears · 2023-03-22T09:40:02Z

So do you need more of my help to approve this PL?

test/parallel/test-tls-secure-context-bio.js

bnoordhuis · 2023-03-22T10:14:00Z

/home/runner/work/node/node/test/parallel/test-tls-secure-context-bio.js
Error:    9:7   error  'assert' is assigned a value but never used    no-unused-vars
Error:   23:31  error  Newline required at end of file but not found  eol-last

GauriSpears · 2023-03-22T10:29:31Z

Done.

GauriSpears · 2023-03-22T15:58:18Z

Ok, it looks like my test fails on some configurations. I'll investigate further and rewrite it.

quickdevel · 2023-03-23T06:28:54Z

Test failed because specified key cannot be processed without gost-engine.

GauriSpears · 2023-03-23T10:48:44Z

Test failed because specified key cannot be processed without gost-engine.

Yep) I understood it, that's why now I'm rewriting the test. The trick was that Node.js with statically linked OpenSSL loads engine even without "crypto.setEngine" so I was sure that engine would be needed later to create connection but not to load a .pem. That's another oddity, I wrote about it in issue #43653 .

GauriSpears · 2023-03-24T10:43:38Z

OK, I've rewritten test. It's rather low-level but works.

GauriSpears · 2023-03-28T02:38:16Z

Hi! Could you re-run workflows please?

GauriSpears · 2023-03-29T04:05:54Z

@bnoordhuis Should I fix anything else?

nodejs-github-bot · 2023-05-17T14:58:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51849/

GauriSpears · 2023-05-18T13:45:06Z

I've added the commit-queue label but I'm not 100% sure if the bot will merge it when the CI run failed. Let's see.

It looks like the new CI is successful. Should you add the "commit-queue" label again?

nodejs-github-bot · 2023-05-18T16:28:46Z

Landed in 10b21e5

NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys. So I switched to OpenSSL'w own protected memory bu ffers. Fixes: nodejs#47008 PR-URL: nodejs#47160 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys. So I switched to OpenSSL'w own protected memory bu ffers. Fixes: #47008 PR-URL: #47160 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys. So I switched to OpenSSL'w own protected memory bu ffers. Fixes: nodejs#47008 PR-URL: nodejs#47160 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309

Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309

Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309

Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309

Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309

Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309

* chore: bump node in DEPS to v18.17.0 * chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch Xref: nodejs/node#46930 manually sync patch to minor upstream code shear * chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch Xref: nodejs/node#48248 manually sync patch to minor upstream code shear * chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#47824 chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it * chore: update api_pass_oomdetails_to_oomerrorcallback.patch Xref: nodejs/node#47695 manually sync patch to minor upstream code shear * chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch Xref: nodejs/node#46979 (upstreamed patch) Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related) * chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch Xref: nodejs/node#47274 manually sync patch to minor upstream code shear some tests moved from sequential to parallel * chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch patch is no longer needed due to upstream bump to ada 2.2.0 * chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch Xref: nodejs/node#47339 patch is no longer needed due to upstream bump to ada 2.2.0 * chore: rebuild filenames.json several files removed/added/changed upstream * chore: update build_add_gn_build_files.patch upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742 * chore: update fix_crypto_tests_to_run_with_bssl.patch Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: ftbfs in node dep ada * fix: ftbfs in node dep uvwasi * chore: rebuild patches * chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: work around Node 18 isURL() regression * chore: sort script/node-disabled-tests.json alphabetically * test: add parallel/test-snapshot-argv1 to disabled list test: add parallel/test-snapshot-namespaced-builtin to disabled list We don't support that type of snapshotting at the moment. * chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error fails upstream in v18.x on my box as well * ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set * fixup! fix: work around Node 18 isURL() regression fix: infinite loop regression * fixup! fix: work around Node 18 isURL() regression * chore: patch fixtures/errors/force_colors.snapshot The line numbers in the stacktrace from our v8 build don't match what Node's tests are expecting, so update the stacktrace to match our build. The specific numbers probably aren't t needed for the force_colors test, which is trying to see whether or not the lines are greyed out. One option is to upstream a test change to stop hardcoding the stacktrace. * fixup! fix: work around Node 18 isURL() regression fix; pull in upstream bugfix * fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js * chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <[email protected]>

This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs#47160

This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: #47160 PR-URL: #49206 Reviewed-By: Michael Dawson <[email protected]>

* chore: bump node in DEPS to v18.17.0 * chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch Xref: nodejs/node#46930 manually sync patch to minor upstream code shear * chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch Xref: nodejs/node#48248 manually sync patch to minor upstream code shear * chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#47824 chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it * chore: update api_pass_oomdetails_to_oomerrorcallback.patch Xref: nodejs/node#47695 manually sync patch to minor upstream code shear * chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch Xref: nodejs/node#46979 (upstreamed patch) Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related) * chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch Xref: nodejs/node#47274 manually sync patch to minor upstream code shear some tests moved from sequential to parallel * chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch patch is no longer needed due to upstream bump to ada 2.2.0 * chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch Xref: nodejs/node#47339 patch is no longer needed due to upstream bump to ada 2.2.0 * chore: rebuild filenames.json several files removed/added/changed upstream * chore: update build_add_gn_build_files.patch upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742 * chore: update fix_crypto_tests_to_run_with_bssl.patch Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: ftbfs in node dep ada * fix: ftbfs in node dep uvwasi * chore: rebuild patches * chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: work around Node 18 isURL() regression * chore: sort script/node-disabled-tests.json alphabetically * test: add parallel/test-snapshot-argv1 to disabled list test: add parallel/test-snapshot-namespaced-builtin to disabled list We don't support that type of snapshotting at the moment. * chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error fails upstream in v18.x on my box as well * ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set * fixup! fix: work around Node 18 isURL() regression fix: infinite loop regression * fixup! fix: work around Node 18 isURL() regression * chore: patch fixtures/errors/force_colors.snapshot The line numbers in the stacktrace from our v8 build don't match what Node's tests are expecting, so update the stacktrace to match our build. The specific numbers probably aren't t needed for the force_colors test, which is trying to see whether or not the lines are greyed out. One option is to upstream a test change to stop hardcoding the stacktrace. * fixup! fix: work around Node 18 isURL() regression fix; pull in upstream bugfix * fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js * chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <[email protected]>

This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs#47160 PR-URL: nodejs#49206 Reviewed-By: Michael Dawson <[email protected]>

This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: #47160 PR-URL: #49206 Reviewed-By: Michael Dawson <[email protected]>

* chore: bump node in DEPS to v18.17.0 * chore: update build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch Xref: nodejs/node#46930 manually sync patch to minor upstream code shear * chore: update build_ensure_native_module_compilation_fails_if_not_using_a_new.patch Xref: nodejs/node#48248 manually sync patch to minor upstream code shear * chore: update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#47824 chore: upstream func throwIfUnsupportedURLProtocol() has been removed, so no need to patch it * chore: update api_pass_oomdetails_to_oomerrorcallback.patch Xref: nodejs/node#47695 manually sync patch to minor upstream code shear * chore: remove fix_prevent_changing_functiontemplateinfo_after_publish.patch Xref: nodejs/node#46979 (upstreamed patch) Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2718147 (related) * chore: update fix_adapt_debugger_tests_for_upstream_v8_changes.patch Xref: nodejs/node#47274 manually sync patch to minor upstream code shear some tests moved from sequential to parallel * chore: remove fix_libc_buffer_overflow_in_string_view_ctor.patch Xref: fix_libc_buffer_overflow_in_string_view_ctor.patch patch is no longer needed due to upstream bump to ada 2.2.0 * chore: remove fix_preventing_potential_oob_in_ada_no_scheme_parsing.patch Xref: nodejs/node#47339 patch is no longer needed due to upstream bump to ada 2.2.0 * chore: rebuild filenames.json several files removed/added/changed upstream * chore: update build_add_gn_build_files.patch upstream dep histogram 0.11.7 moved its include path from src/ to include/ Xref: nodejs/node#47742 * chore: update fix_crypto_tests_to_run_with_bssl.patch Xref: nodejs/node#47160 BoringSSL doesn't support BIO_s_secmem() (a secure heap variant of BIO_s_mem()), so use BIO_s_mem() instead. Related discussion of secure heap support in BoringSSL: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: ftbfs in node dep ada * fix: ftbfs in node dep uvwasi * chore: rebuild patches * chore: update fix_handle_boringssl_and_openssl_incompatibilities.patch Upstream used `BIO_s_secmem()`, a secure heap variant of `BIO_s_mem()`. BoringSSL doesn't support it, so this PR opts for `BIO_s_mem()` instead. Upstream Node.js change that prompted this: nodejs/node#47160 Related discussion of BoringSSL support of secure heap: https://boringssl-review.googlesource.com/c/boringssl/+/54309 * fix: work around Node 18 isURL() regression * chore: sort script/node-disabled-tests.json alphabetically * test: add parallel/test-snapshot-argv1 to disabled list test: add parallel/test-snapshot-namespaced-builtin to disabled list We don't support that type of snapshotting at the moment. * chore: disable flaky node test parallel/test-dgram-send-cb-quelches-error fails upstream in v18.x on my box as well * ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set * fixup! fix: work around Node 18 isURL() regression fix: infinite loop regression * fixup! fix: work around Node 18 isURL() regression * chore: patch fixtures/errors/force_colors.snapshot The line numbers in the stacktrace from our v8 build don't match what Node's tests are expecting, so update the stacktrace to match our build. The specific numbers probably aren't t needed for the force_colors test, which is trying to see whether or not the lines are greyed out. One option is to upstream a test change to stop hardcoding the stacktrace. * fixup! fix: work around Node 18 isURL() regression fix; pull in upstream bugfix * fixup! ci: ensure spawned node tests have ELECTRON_RUN_AS_NODE set chore: do not inject ELECTRON_RUN_AS_NODE in test-assert-colors.js * chore: disable flaky node test parallel/test-debugger-random-port-with-inspect-port --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <[email protected]>

This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs/node#47160 PR-URL: nodejs/node#49206 Reviewed-By: Michael Dawson <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 19, 2023

bnoordhuis reviewed Mar 19, 2023

View reviewed changes

src/crypto/crypto_context.cc Outdated Show resolved Hide resolved

GauriSpears requested a review from bnoordhuis March 19, 2023 15:52

bnoordhuis reviewed Mar 20, 2023

View reviewed changes

src/crypto/crypto_context.cc Outdated Show resolved Hide resolved

bnoordhuis reviewed Mar 22, 2023

View reviewed changes

test/parallel/test-tls-secure-context-bio.js Outdated Show resolved Hide resolved

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2023

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023

nodejs-github-bot merged commit 10b21e5 into nodejs:main May 18, 2023

targos mentioned this pull request Jun 4, 2023

v20.3.0 release proposal #48332

Merged

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

tniessen added a commit to tniessen/node that referenced this pull request Aug 16, 2023

test: fix compiler warning in NodeCryptoEnv

5d79fb2

This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: nodejs#47160

tniessen mentioned this pull request Aug 16, 2023

test: fix compiler warning in NodeCryptoEnv #49206

Merged

targos pushed a commit that referenced this pull request Nov 27, 2023

test: fix compiler warning in NodeCryptoEnv

ddebd29

This fixes a warning in line 26: "warning: value computed is not used" when calling BIO_seek(). Refs: #47160 PR-URL: #49206 Reviewed-By: Michael Dawson <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

crypto: use openssl's own memory BIOs in crypto_context.cc #47160

crypto: use openssl's own memory BIOs in crypto_context.cc #47160

GauriSpears commented Mar 19, 2023 •

edited

Loading

nodejs-github-bot commented Mar 19, 2023

GauriSpears commented Mar 19, 2023

GauriSpears commented Mar 20, 2023

GauriSpears commented Mar 20, 2023

addaleax commented Mar 20, 2023

GauriSpears commented Mar 20, 2023

GauriSpears commented Mar 21, 2023

GauriSpears commented Mar 21, 2023 •

edited

Loading

bnoordhuis commented Mar 21, 2023

GauriSpears commented Mar 22, 2023

GauriSpears commented Mar 22, 2023 •

edited

Loading

bnoordhuis commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

bnoordhuis commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

bnoordhuis commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

quickdevel commented Mar 23, 2023

GauriSpears commented Mar 23, 2023 •

edited

Loading

GauriSpears commented Mar 24, 2023

GauriSpears commented Mar 28, 2023

GauriSpears commented Mar 29, 2023

nodejs-github-bot commented May 17, 2023

GauriSpears commented May 18, 2023

nodejs-github-bot commented May 18, 2023

crypto: use openssl's own memory BIOs in crypto_context.cc #47160

crypto: use openssl's own memory BIOs in crypto_context.cc #47160

Conversation

GauriSpears commented Mar 19, 2023 • edited Loading

nodejs-github-bot commented Mar 19, 2023

GauriSpears commented Mar 19, 2023

GauriSpears commented Mar 20, 2023

GauriSpears commented Mar 20, 2023

addaleax commented Mar 20, 2023

GauriSpears commented Mar 20, 2023

GauriSpears commented Mar 21, 2023

GauriSpears commented Mar 21, 2023 • edited Loading

bnoordhuis commented Mar 21, 2023

GauriSpears commented Mar 22, 2023

GauriSpears commented Mar 22, 2023 • edited Loading

bnoordhuis commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

bnoordhuis commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

bnoordhuis commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

GauriSpears commented Mar 22, 2023

quickdevel commented Mar 23, 2023

GauriSpears commented Mar 23, 2023 • edited Loading

GauriSpears commented Mar 24, 2023

GauriSpears commented Mar 28, 2023

GauriSpears commented Mar 29, 2023

nodejs-github-bot commented May 17, 2023

GauriSpears commented May 18, 2023

nodejs-github-bot commented May 18, 2023

GauriSpears commented Mar 19, 2023 •

edited

Loading

GauriSpears commented Mar 21, 2023 •

edited

Loading

GauriSpears commented Mar 22, 2023 •

edited

Loading

GauriSpears commented Mar 23, 2023 •

edited

Loading