Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove remaining SSL_OP_NETSCAPE_*_BUG #47066

Merged

Conversation

tniessen
Copy link
Member

I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443.

Refs: #46954
Refs: openssl/openssl#20443

I missed these two in db81af6 because I
went by OpenSSL's list of obsolete flags, which turned out to be
incomplete. See openssl/openssl#20443.

Refs: nodejs#46954
Refs: openssl/openssl#20443
@tniessen tniessen added tls Issues and PRs related to the tls subsystem. crypto Issues and PRs related to the crypto subsystem. openssl Issues and PRs related to the OpenSSL dependency. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 13, 2023
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2023
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit 51380f2 into nodejs:main Mar 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 51380f2

tniessen added a commit to tniessen/node that referenced this pull request Mar 13, 2023
None of these constants have any effect in recent OpenSSL versions, not
even in Node.js release lines that still use OpenSSL 1.1.1.

It is likely rare that these options are still used (intentionally), and
removing them is unlikely to break any existing applications. These
constants can only be passed to the secureOptions option of
tls.createSecureContext() and related APIs, and a value of undefined
will be ignored. Similarly, if a bitwise combination of multiple options
is used, undefined constants will not change the behavior because
(a | undefined | b) === a | b for (small non-negative) integers a and b.

Refs: nodejs#46954
Refs: nodejs#47066
tniessen added a commit to tniessen/node that referenced this pull request Mar 13, 2023
None of these constants have any effect in recent OpenSSL versions, not
even in Node.js release lines that still use OpenSSL 1.1.1.

It is likely rare that these options are still used (intentionally), and
removing them is unlikely to break any existing applications. These
constants can only be passed to the secureOptions option of
tls.createSecureContext() and related APIs, and a value of undefined
will be ignored. Similarly, if a bitwise combination of multiple options
is used, undefined constants will not change the behavior because
(a | undefined | b) === (a | b) for (small) integers a and b.

Refs: nodejs#46954
Refs: nodejs#47066
targos pushed a commit that referenced this pull request Mar 14, 2023
I missed these two in db81af6 because I
went by OpenSSL's list of obsolete flags, which turned out to be
incomplete. See openssl/openssl#20443.

Refs: #46954
Refs: openssl/openssl#20443
PR-URL: #47066
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Mar 21, 2023
None of these constants have any effect in recent OpenSSL versions, not
even in Node.js release lines that still use OpenSSL 1.1.1.

It is likely rare that these options are still used (intentionally), and
removing them is unlikely to break any existing applications. These
constants can only be passed to the secureOptions option of
tls.createSecureContext() and related APIs, and a value of undefined
will be ignored. Similarly, if a bitwise combination of multiple options
is used, undefined constants will not change the behavior because
(a | undefined | b) === (a | b) for (small) integers a and b.

Refs: #46954
Refs: #47066
PR-URL: #47073
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
I missed these two in db81af6 because I
went by OpenSSL's list of obsolete flags, which turned out to be
incomplete. See openssl/openssl#20443.

Refs: #46954
Refs: openssl/openssl#20443
PR-URL: #47066
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants