Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: cleanup cork logic #46664

Closed
wants to merge 1 commit into from
Closed

http: cleanup cork logic #46664

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Feb 15, 2023

No description provided.

@ronag ronag added the http Issues or PRs related to the http subsystem. label Feb 15, 2023
@ronag ronag requested a review from mcollina February 15, 2023 08:52
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 15, 2023
@ronag ronag force-pushed the clenaup-cork branch 3 times, most recently from 59c4f9c to f862c81 Compare February 15, 2023 08:54
mcollina
mcollina approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Feb 15, 2023
@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Feb 15, 2023
@mscdex mscdex added the needs-citgm PRs that need a CITGM CI run. label Feb 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49575/

@ronag ronag added the review wanted PRs that need reviews. label Feb 21, 2023
@ronag
Copy link
Member Author

ronag commented Feb 21, 2023

@nodejs/http

mcollina
mcollina approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50031/

@aduh95
Copy link
Contributor

aduh95 commented Feb 26, 2023

Can you rebase to fix the conflicts please?

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2023
This was referenced Feb 28, 2023
Open
Open
@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label May 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@mcollina
Copy link
Member

@ronag ping

@ronag ronag force-pushed the clenaup-cork branch 4 times, most recently from 82e64b3 to 7e3de7f Compare May 12, 2024 09:57
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 12, 2024

Linter is failing

@ronag ronag closed this May 12, 2024
@ronag
Copy link
Member Author

ronag commented May 12, 2024

I think this has been done already in a different way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. review wanted PRs that need reviews. stalled Issues and PRs that are stalled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @aduh95 @mcollina @mscdex