Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: back snapshot I/O with a std::vector sink #46463

Merged
merged 2 commits into from
Feb 3, 2023
Merged

src: back snapshot I/O with a std::vector sink #46463

merged 2 commits into from
Feb 3, 2023

Conversation

joyeecheung
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49293/

addaleax
addaleax approved these changes Feb 1, 2023
View reviewed changes
src/node_snapshotable.cc Outdated Show resolved Hide resolved
@addaleax addaleax mentioned this pull request Feb 1, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49297/

bnoordhuis
bnoordhuis approved these changes Feb 2, 2023
View reviewed changes
src/node_snapshotable.cc Outdated Show resolved Hide resolved
src/node_snapshotable.cc Outdated Show resolved Hide resolved
src/node_snapshotable.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49328/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit a466fea into nodejs:main Feb 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in a466fea

@addaleax addaleax mentioned this pull request Feb 4, 2023
Merged
tniessen added a commit to tniessen/node that referenced this pull request Feb 4, 2023
@tniessen
src: check return value of ftell()
f60ad96 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: nodejs#46463
@tniessen tniessen mentioned this pull request Feb 4, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 5, 2023
Open
22 tasks
nodejs-github-bot pushed a commit that referenced this pull request Feb 6, 2023
@tniessen
src: check return value of ftell()
1e9ca45 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: #46463
PR-URL: #46495
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 6, 2023
@addaleax
src: allow blobs in addition to FILE*s in embedder snapshot API
d592630 
This is a shared follow-up to 06bb6b4 and a466fea
now that both have been merged.

PR-URL: #46491
Refs: #45888
Refs: #46463
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@joyeecheung @MylesBorins
src: back snapshot I/O with a std::vector sink
6cf860d 
PR-URL: #46463
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@tniessen @MylesBorins
src: check return value of ftell()
1a808a4 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: #46463
PR-URL: #46495
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@addaleax @MylesBorins
src: allow blobs in addition to FILE*s in embedder snapshot API
c34bac2 
This is a shared follow-up to 06bb6b4 and a466fea
now that both have been merged.

PR-URL: #46491
Refs: #45888
Refs: #46463
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@joyeecheung @danielleadams
src: back snapshot I/O with a std::vector sink
8dfa748 
PR-URL: #46463
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen @danielleadams
src: check return value of ftell()
bc9a577 
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
to the vector allocator and fread().

Refs: #46463
PR-URL: #46495
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@legendecas legendecas legendecas approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @nodejs-github-bot @bnoordhuis @jasnell @addaleax @legendecas @RaisinTen