Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note about major release rotation #46436

Merged
merged 1 commit into from
Feb 2, 2023
Merged

doc: add note about major release rotation #46436

merged 1 commit into from
Feb 2, 2023

Conversation

RafaelGSS
Copy link
Member

Fixes: nodejs/Release#765

cc: @nodejs/releasers

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@RafaelGSS RafaelGSS marked this pull request as ready for review January 31, 2023 01:09
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 31, 2023
mcollina
mcollina approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mhdawson
mhdawson approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS force-pushed the add-note-major-release-rotation branch from 3f5cd28 to bb6badf Compare January 31, 2023 21:25
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6099637 into nodejs:main Feb 2, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 6099637

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@RafaelGSS @MylesBorins
doc: add note about major release rotation
905a675 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #46436
Fixes: nodejs/Release#765
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@RafaelGSS @danielleadams
doc: add note about major release rotation
4165cf3 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #46436
Fixes: nodejs/Release#765
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Major release rotation?
7 participants
@RafaelGSS @nodejs-github-bot @mcollina @ruyadorno @GeoffreyBooth @lpinca @mhdawson