[v19.x backport] http: join authorization headers #46240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#45982 Fixes: nodejs#45699 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
lib / src
anonrig
approved these changes
Jan 18, 2023
github-actions
bot
removed
the
request-ci
anonrig
added
the
author ready
RafaelGSS
added
the
fast-track
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
|
I want to include it in the next v19 release |
|
cc: @marco-ippolito |
Trott
reviewed
Jan 19, 2023
| @@ -2426,6 +2426,13 @@ as an argument to any listeners on the event. | |||
| <!-- YAML | |||
| added: v0.1.5 | |||
| changes: | |||
| - version: REPLACEME | |||
| pr-url: https://github.com/nodejs/node/pull/45982 | |||
There was a problem hiding this comment.
Do you need to update this PR URL to be 46240 or add it as a second pr-url entry? Or do we not do that for backports?
There was a problem hiding this comment.
We don't do that for backports. Example https://github.com/nodejs/node/pull/42298/files.
Qard
approved these changes
Jan 19, 2023
|
Landed in 069a30b |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
PR-URL: #45982 Backport-PR-URL: #46240 Fixes: #45699 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #45982
Fixes: #45699
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Paolo Insogna [email protected]