test,esm: validate more edge cases for dynamic imports #46059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
GeoffreyBooth
approved these changes
Jan 2, 2023
| const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [ | ||
| '--no-warnings', | ||
| '--experimental-loader', | ||
| fixtures.fileURL('es-module-loaders/never-settling-resolve-step/loader.mjs'), |
There was a problem hiding this comment.
Not for this PR, but I've noticed that in most uses of fixtures.fileURL we treat it as if it's returning a string when in fact it's a URL, and I guess it's getting cast to a string here. We might want to change the function.
There was a problem hiding this comment.
Does it matter? FWIW I prefer it returning a URL as now.
JakobJingleheimer
approved these changes
Jan 3, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
JungMinu
approved these changes
Jan 4, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9b1ed04 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46059 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
PR-URL: #46059 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46059 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46059 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/loaders this is relevant to the off-threading discussions, the idea is to make sure that using dynamic import doesn't break the expected order of operations if the main thread is being frozen.