Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document server.listen return val #4590

Closed
wants to merge 1 commit into from
Closed

document server.listen return val #4590

wants to merge 1 commit into from

Conversation

Sequoia
Copy link
Contributor

@Sequoia Sequoia commented Jan 8, 2016

closes #4571

@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 8, 2016

Incidentally, do all the server methods return this for chaining? Would be worth noting if so. I can create PR to doc this if someone can confirm; else I can look into it at some point.

@jasnell
Copy link
Member

jasnell commented Jan 8, 2016

LGTM
@Sequoia ... one quick nit: the commit message should be updated to conform to our style guidelines. See: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit :-)

@jasnell jasnell added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Jan 8, 2016
@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 8, 2016

Is the subsystem "docs" or "http"?

@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 8, 2016

looks like "doc" from other commits, I'll go with that.

@Sequoia
doc: document server.listen return value
432aced 
The server method returns `self` in order to
allow chaining.

closes nodejs#4571
@Sequoia Sequoia force-pushed the document-server-listen-return-val branch from 1f36437 to 432aced Compare January 8, 2016 18:48
@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 8, 2016

OK lmk if it's still not in compliance! 😸

@Sequoia Sequoia mentioned this pull request Jan 8, 2016
Closed
@silverwind
Copy link
Contributor

do all the server methods return this for chaining?

They should, but there may be a few methods around that don't. If you find any that return undefined, we can likely change them.

@ryansobol
Copy link
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Jan 11, 2016
@Sequoia @silverwind
doc: document http's server.listen return value
9456f50 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@silverwind
Copy link
Contributor

Thanks! Landed with slight tweaks to the message in 9456f50.

@silverwind silverwind closed this Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
@Sequoia
doc: document http's server.listen return value
749aaa7 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
@Sequoia
doc: document http's server.listen return value
b181e26 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
@Sequoia
doc: document http's server.listen return value
80ad952 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
@Sequoia
doc: document http's server.listen return value
bb3af99 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
@Sequoia
doc: document http's server.listen return value
19f21ab 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@Sequoia
doc: document http's server.listen return value
5b45a46 
The server method returns `self` in order to allow chaining.

PR-URL: #4590
Fixes: #4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Sequoia
doc: document http's server.listen return value
e42869f 
The server method returns `self` in order to allow chaining.

PR-URL: nodejs#4590
Fixes: nodejs#4571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@npm-robot npm-robot mentioned this pull request Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document return value of http.server.listen
5 participants
@Sequoia @jasnell @silverwind @ryansobol @MylesBorins