Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] src: add support for externally shared js builtins #45867

Closed
wants to merge 1 commit into from
Closed

[v16.x] src: add support for externally shared js builtins #45867

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Refs: #44000

  • add infra to support externally shared js builtins in support of distos that want to externalize deps that include JS/WASM instead of native code
  • add support for externalizing
    • cjs_module_lexer/lexer
    • cjs_module_lexer/dist/lexer
    • undici/undici

Signed-off-by: Michael Dawson [email protected]

PR-URL: #44376
Reviewed-By: Gireesh Punathil [email protected]

@mhdawson
src: add support for externally shared js builtins
1e27ddc 
Refs: nodejs#44000

- add infra to support externally shared js builtins in
  support of distos that want to externalize deps that
  include JS/WASM instead of native code
- add support for externalizing
  - cjs_module_lexer/lexer
  - cjs_module_lexer/dist/lexer
  - undici/undici

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#44376
Reviewed-By: Gireesh Punathil <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/startup
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Dec 14, 2022
@mhdawson mhdawson mentioned this pull request Dec 14, 2022
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48489/

@GeoffreyBooth
Copy link
Member

cc @guybedford

GeoffreyBooth
GeoffreyBooth approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

mcollina
mcollina approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@legendecas legendecas changed the title src: add support for externally shared js builtins [v16.x] src: add support for externally shared js builtins Dec 15, 2022
This was referenced Dec 17, 2022
Open
Open
Open
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49671/

@github-actions github-actions bot mentioned this pull request Feb 19, 2023
Open
21 tasks
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49722/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49733/

This was referenced Feb 20, 2023
Open
Open
BethGriggs pushed a commit that referenced this pull request Mar 23, 2023
@mhdawson @BethGriggs
src: add support for externally shared js builtins
6a01d39 
Refs: #44000

- add infra to support externally shared js builtins in
  support of distos that want to externalize deps that
  include JS/WASM instead of native code
- add support for externalizing
  - cjs_module_lexer/lexer
  - cjs_module_lexer/dist/lexer
  - undici/undici

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44376
Backport-PR-URL: #45867
Reviewed-By: Gireesh Punathil <[email protected]>
@BethGriggs
Copy link
Member

Landed in 6a01d39

@BethGriggs BethGriggs closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @nodejs-github-bot @GeoffreyBooth @BethGriggs @mcollina @richardlau