Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: split parallel fs-watch-recursive tests #45865

Merged
merged 1 commit into from
Dec 20, 2022
Merged

test: split parallel fs-watch-recursive tests #45865

merged 1 commit into from
Dec 20, 2022

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Dec 14, 2022 •
edited by aduh95
Loading

Split test-fs-watch-recursive for a better understanding of the failing ones.

Fixes: #45535

CC @bnoordhuis

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 14, 2022
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48488/

@anonrig anonrig force-pushed the test.parallel/test-fs-watch-recursive branch from 194c82f to 6f81a76 Compare December 15, 2022 00:07
@anonrig anonrig requested a review from aduh95 December 15, 2022 00:07
@anonrig anonrig force-pushed the test.parallel/test-fs-watch-recursive branch from 6f81a76 to 00dbd16 Compare December 15, 2022 00:12
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48492/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48502/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48532/

@github-actions github-actions bot mentioned this pull request Dec 17, 2022
Open
13 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48538/

@github-actions github-actions bot mentioned this pull request Dec 18, 2022
Open
12 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48553/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48563/

@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48592/

lpinca
lpinca approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48636/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8398f85 into nodejs:main Dec 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8398f85

This was referenced Dec 21, 2022
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@anonrig @targos
test: split parallel fs-watch-recursive tests
e6da353 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@anonrig @RafaelGSS
test: split parallel fs-watch-recursive tests
dd0ac7c 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@anonrig @RafaelGSS
test: split parallel fs-watch-recursive tests
c6c0947 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@anonrig @juanarbol
test: split parallel fs-watch-recursive tests
57e9ab1 
PR-URL: #45865
Fixes: #45535
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
@juanarbol juanarbol added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jan 31, 2023
@juanarbol
Copy link
Member

CI does not seem to like this for v18.x in Linux jobs, see https://ci.nodejs.org/job/node-test-pull-request/49261/

cheungxi pushed a commit to cheungxi/node that referenced this pull request Feb 1, 2023
@anonrig @cheungxi
test: split parallel fs-watch-recursive tests
fab102f 
PR-URL: nodejs#45865
Fixes: nodejs#45535
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test.parallel/test-fs-watch-recursive
7 participants
@anonrig @nodejs-github-bot @juanarbol @jasnell @lpinca @targos @aduh95