Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix description about the latest-codename #4583

Closed
wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

@JungMinu JungMinu commented Jan 8, 2016

fix description about the latest LTS release download page
to make it clear

fix description about the latest LTS release download page
to make it clear
@JungMinu JungMinu added the doc Issues and PRs related to the documentations. label Jan 8, 2016
@JungMinu JungMinu self-assigned this Jan 8, 2016
@rvagg
Copy link
Member

rvagg commented Jan 8, 2016

I guess this was my stuff-up, thanks for fixing, lgtm

@cjihrig
Copy link
Contributor

cjihrig commented Jan 8, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jan 8, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Jan 8, 2016

@JungMinu ... quick nit.. not sure if you noticed but you created the branch for this in the main nodejs/node repo. We want to try to avoid folks creating branches in the main repo for PRs.

JungMinu added a commit that referenced this pull request Jan 8, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 8, 2016

Landed in fde18b2

@jasnell jasnell closed this Jan 8, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 11, 2016
@JungMinu
Copy link
Member Author

@jasnell sorry, it was a mistake

@JungMinu JungMinu deleted the JungMinu-patch-codename branch January 12, 2016 01:30
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 12, 2016

No worries @JungMinu :-) I've done it before too

MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: nodejs#4583
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants