test: add CryptoKey transferring tests #45811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
I recommend hiding whitespace changes for review. |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
11 tasks
aduh95
approved these changes
Dec 11, 2022
panva
added
the
author ready
panva
force-pushed
the
add-cryptokey-transferrable-tests
branch
from
8e3a250
to
7941108
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
11 tasks
This comment was marked as outdated.
This comment was marked as outdated.
13 tasks
|
cc @nodejs/crypto |
12 tasks
This was referenced Dec 15, 2022
jasnell
approved these changes
Dec 16, 2022
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 992fba4 |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #45811 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #45811 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the worker thread, message port, postMessage KeyObject tests to also cover CryptoKey instances.