Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: order list alphabetically in test-bootstrap-modules #45808

Merged
merged 1 commit into from
Dec 11, 2022
Merged

test: order list alphabetically in test-bootstrap-modules #45808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/parallel/test-bootstrap-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const assert = require('assert');

const expectedModules = new Set([
'Internal Binding async_wrap',
'Internal Binding blob',
'Internal Binding buffer',
'Internal Binding builtins',
'Internal Binding config',
Expand All @@ -18,8 +19,8 @@ const expectedModules = new Set([
'Internal Binding credentials',
'Internal Binding errors',
'Internal Binding fs',
'Internal Binding mksnapshot',
'Internal Binding messaging',
'Internal Binding mksnapshot',
'Internal Binding module_wrap',
'Internal Binding options',
'Internal Binding performance',
Expand All @@ -35,6 +36,7 @@ const expectedModules = new Set([
'Internal Binding util',
'Internal Binding wasm_web_api',
'Internal Binding worker',
'NativeModule async_hooks',
'NativeModule buffer',
'NativeModule events',
'NativeModule fs',
Expand Down Expand Up @@ -87,19 +89,17 @@ const expectedModules = new Set([
'NativeModule internal/util/inspect',
'NativeModule internal/util/iterable_weak_map',
'NativeModule internal/util/types',
'NativeModule internal/v8/startup_snapshot',
'NativeModule internal/validators',
'NativeModule internal/vm',
'NativeModule internal/vm/module',
'NativeModule internal/wasm_web_api',
'NativeModule internal/worker/js_transferable',
'Internal Binding blob',
'NativeModule async_hooks',
'NativeModule path',
'NativeModule querystring',
'NativeModule timers',
'NativeModule url',
'NativeModule util',
'NativeModule internal/v8/startup_snapshot',
'NativeModule vm',
]);

Expand Down Expand Up @@ -132,10 +132,10 @@ if (!common.isMainThread) {
'NativeModule internal/streams/writable',
'NativeModule internal/worker',
'NativeModule internal/worker/io',
'NativeModule worker_threads',
'NativeModule stream',
'NativeModule stream/promises',
'NativeModule string_decoder',
'NativeModule worker_threads',
].forEach(expectedModules.add.bind(expectedModules));
}

Expand Down