Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] backport utf8 performance improvements #45650

Closed
wants to merge 6 commits into from
Closed

[v18.x backport] backport utf8 performance improvements #45650

wants to merge 6 commits into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 27, 2022

This is my first backport. If the time is right, I'd like to backport UTF8 encoding performance improvements, so that LTS users can access to the performance boosts.

I'm trying to backport the following changes to the v18 release line:

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Nov 27, 2022
anonrig and others added 6 commits November 27, 2022 19:01
@anonrig
util: improve textdecoder decode performance
367d631 
PR-URL: nodejs#45294
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
benchmark: fix text-decoder benchmark
f5e3920 
PR-URL: nodejs#45363
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
benchmark: add parameters to text-decoder benchmark
22e9f5b 
PR-URL: nodejs#45363
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
util: improve text-decoder performance
26fbc98 
PR-URL: nodejs#45363
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig
util: improve text decoder performance
8dea4eb 
PR-URL: nodejs#45388
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@anonrig @addaleax
util: add fast path for utf8 encoding
d86c37f 
Co-authored-by: Anna Henningsen <[email protected]>
PR-URL: nodejs#45412
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@targos
Copy link
Member

targos commented Nov 28, 2022

I appreciate the effort, but v18.x is Active LTS, so all changes should automatically be backported to it by releasers. You can add the lts-watch-v18.x label to make sure it happens.

@anonrig
Copy link
Member Author

anonrig commented Nov 28, 2022

Thanks @targos!

@anonrig anonrig closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anonrig @targos @nodejs-github-bot