src: use `enum class` instead of `enum` in node_i18n #45646

deokjinkim · 2022-11-27T11:23:54Z

"enum class" has more advantages than "enum" because it's strongly typed and scoped.

Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class

tniessen · 2022-11-27T12:49:17Z

src/node_i18n.h

@@ -42,7 +42,7 @@ bool InitializeICUDirectory(const std::string& path);

 void SetDefaultTimeZone(const char* tzid);

-enum idna_mode {
+enum class idna_mode {


I suggest removing the IDNA_ prefix from the members of idna_mode since the scope is changing. For example, idna_mode::IDNA_STRICT should just be idna_mode::STRICT.

I think good suggestion from a clean code point of view. Removed IDNA_ prefix.

"enum class" has more advantages than "enum" because it's strongly typed and scoped. Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class

deokjinkim · 2022-11-28T04:01:44Z

@tniessen BTW, I have one question about test. For now, Build Windows and Coverage Windows are failed, but I don't know why these tests are failed. It's very helpful if you let me know how I can resolve this case.

targos · 2022-11-28T06:59:44Z

Windows errors:

https://github.com/nodejs/node/actions/runs/3561646551/jobs/5983757408#step:6:2624

D:\a\node\node\src\node_i18n.h(53,3): error C2143: syntax error: missing '}' before 'constant' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(53,3): error C2059: syntax error: 'constant' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(54,1): error C2143: syntax error: missing ';' before '}' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(61,17): error C2061: syntax error: identifier 'idna_mode' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(139,1): error C2059: syntax error: '}' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(139,1): error C2143: syntax error: missing ';' before '}' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\inspector_socket.h(12,16): error C2143: syntax error: missing ';' before '{' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\inspector_socket.h(12,16): error C2447: '{': missing function header (old-style formal list?) [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\inspector_socket_server.h(85,25): error C2061: syntax error: identifier 'InspectorSocket' [D:\a\node\node\libnode.vcxproj]

This change is needed to fix error of window build.

src/node_i18n.h

deokjinkim · 2022-11-28T14:58:25Z

Windows errors:

https://github.com/nodejs/node/actions/runs/3561646551/jobs/5983757408#step:6:2624

D:\a\node\node\src\node_i18n.h(53,3): error C2143: syntax error: missing '}' before 'constant' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(53,3): error C2059: syntax error: 'constant' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(54,1): error C2143: syntax error: missing ';' before '}' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(61,17): error C2061: syntax error: identifier 'idna_mode' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(139,1): error C2059: syntax error: '}' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\node_i18n.h(139,1): error C2143: syntax error: missing ';' before '}' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\inspector_socket.h(12,16): error C2143: syntax error: missing ';' before '{' [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\inspector_socket.h(12,16): error C2447: '{': missing function header (old-style formal list?) [D:\a\node\node\libnode.vcxproj]
D:\a\node\node\src\inspector_socket_server.h(85,25): error C2061: syntax error: identifier 'InspectorSocket' [D:\a\node\node\libnode.vcxproj]

Thanks to your sharing, I could find solution to avoid error of window build.

nodejs-github-bot · 2022-11-29T16:39:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48236/

nodejs-github-bot · 2022-11-30T01:23:38Z

Landed in 1750a94

"enum class" has more advantages than "enum" because it's strongly typed and scoped. Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class PR-URL: nodejs#45646 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

"enum class" has more advantages than "enum" because it's strongly typed and scoped. Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class PR-URL: #45646 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. needs-ci PRs that need a full CI run. labels Nov 27, 2022

deokjinkim force-pushed the 221127_use_enum_class branch 2 times, most recently from 2ea515e to eb666b2 Compare November 27, 2022 12:13

tniessen reviewed Nov 27, 2022

View reviewed changes

src: use enum class instead of enum in node_i18n

ff3020e

"enum class" has more advantages than "enum" because it's strongly typed and scoped. Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class

deokjinkim force-pushed the 221127_use_enum_class branch from eb666b2 to bc0541f Compare November 28, 2022 01:49

remove IDNA_ prefix from enum idna_mode

5d4cb6f

deokjinkim force-pushed the 221127_use_enum_class branch from bc0541f to 5d4cb6f Compare November 28, 2022 04:14

Add k prefix to each element of enum

b197bf1

This change is needed to fix error of window build.

RaisinTen reviewed Nov 28, 2022

View reviewed changes

src/node_i18n.h Outdated Show resolved Hide resolved

Apply k followed by the name in PascalCase

574af27

RaisinTen approved these changes Nov 28, 2022

View reviewed changes

tniessen approved these changes Nov 28, 2022

View reviewed changes

tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 28, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2022

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Nov 29, 2022

CI Reliability 2022-11-29 nodejs/reliability#443

Open

16 tasks

JungMinu approved these changes Nov 29, 2022

View reviewed changes

github-actions bot mentioned this pull request Nov 30, 2022

CI Reliability 2022-11-30 nodejs/reliability#444

Open

15 tasks

tniessen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 30, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2022

nodejs-github-bot merged commit 1750a94 into nodejs:main Nov 30, 2022

targos mentioned this pull request Dec 12, 2022

v19.3.0 release proposal #45831

Merged

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: use `enum class` instead of `enum` in node_i18n #45646

src: use `enum class` instead of `enum` in node_i18n #45646

deokjinkim commented Nov 27, 2022

tniessen Nov 27, 2022

deokjinkim Nov 28, 2022 •

edited

Loading

deokjinkim commented Nov 28, 2022

targos commented Nov 28, 2022

deokjinkim commented Nov 28, 2022

This comment was marked as outdated.

nodejs-github-bot commented Nov 29, 2022

nodejs-github-bot commented Nov 30, 2022

src: use enum class instead of enum in node_i18n #45646

src: use enum class instead of enum in node_i18n #45646

Conversation

deokjinkim commented Nov 27, 2022

tniessen Nov 27, 2022

Choose a reason for hiding this comment

deokjinkim Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

deokjinkim commented Nov 28, 2022

targos commented Nov 28, 2022

deokjinkim commented Nov 28, 2022

This comment was marked as outdated.

nodejs-github-bot commented Nov 29, 2022

nodejs-github-bot commented Nov 30, 2022

src: use `enum class` instead of `enum` in node_i18n #45646

src: use `enum class` instead of `enum` in node_i18n #45646

deokjinkim Nov 28, 2022 •

edited

Loading